Skip to content

Conversation

@michelpmcdonald
Copy link
Contributor

@michelpmcdonald michelpmcdonald commented Dec 6, 2025

Keep your PR as a Draft until it's ready for Platform review. A PR is ready for Platform review when it has a teammate approval and tests, linting, and settings checks pass CI. See these tips on how to avoid common delays in getting your PR merged.

Summary

Bug in new NOD form, undefined variable, code did not need a variable, so it was completely removed.
The new form is behind a feature flag.
The bug could be reproduced by having all the contestable issues too long to fit on the form and rendered on the overflow addendum page.

Related issue(s)

Testing done

Fix was confirmed by manual testing with NOD json data that forced the CI overflow on the generated PDF and verifying that the overflow notification was properly rendered on the form.

Unfortunately, our PDF generation is not unit testable for our max data test, slight differences in our PDF form fill libraries libraries vary slightly from run to run according to the position of the moon.

Screenshots

image

What areas of the site does it impact?

Notice of Disagreements feb 2025 version of the form. The forms we generate are not visible to our consumers, we send them upstream only to VA intake.

Acceptance criteria

  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants