removed undefined var, not needed #25453
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep your PR as a Draft until it's ready for Platform review. A PR is ready for Platform review when it has a teammate approval and tests, linting, and settings checks pass CI. See these tips on how to avoid common delays in getting your PR merged.
Summary
Bug in new NOD form, undefined variable, code did not need a variable, so it was completely removed.
The new form is behind a feature flag.
The bug could be reproduced by having all the contestable issues too long to fit on the form and rendered on the overflow addendum page.
Related issue(s)
Testing done
Fix was confirmed by manual testing with NOD json data that forced the CI overflow on the generated PDF and verifying that the overflow notification was properly rendered on the form.
Unfortunately, our PDF generation is not unit testable for our max data test, slight differences in our PDF form fill libraries libraries vary slightly from run to run according to the position of the moon.
Screenshots
What areas of the site does it impact?
Notice of Disagreements feb 2025 version of the form. The forms we generate are not visible to our consumers, we send them upstream only to VA intake.
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?