Skip to content

Conversation

@bartlomieju
Copy link
Member

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Dec 8, 2025

Walkthrough

The tests/wpt/runner/expectation.json file was updated to change how the same-origin.html test expectation is handled. The entry was converted from an array containing "non-parsable URL" to an object with an ignore property set to true. This structural change shifts the test configuration from tracking a specific condition to marking the test to be skipped during test runs.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: marking a flaky web platform test as ignored in the expectations file.
Description check ✅ Passed No description was provided, but this is a minimal, straightforward change to test configuration that doesn't require elaboration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 17cdcc2 and 1b01460.

📒 Files selected for processing (1)
  • tests/wpt/runner/expectation.json (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: denoland/deno PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:19:37.808Z
Learning: Applies to tests/specs/**/{__test__.jsonc,*.out} : Output assertions in spec tests should use `__test__.jsonc` inline fields or `.out` files with special matching syntax: `[WILDCARD]`, `[WILDLINE]`, `[WILDCHAR]`, `[WILDCHARS(n)]`, `[UNORDERED_START]`/`[UNORDERED_END]`, and `[# comment]`
📚 Learning: 2025-11-24T16:19:37.808Z
Learnt from: CR
Repo: denoland/deno PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T16:19:37.808Z
Learning: Applies to tests/specs/**/{__test__.jsonc,*.out} : Output assertions in spec tests should use `__test__.jsonc` inline fields or `.out` files with special matching syntax: `[WILDCARD]`, `[WILDLINE]`, `[WILDCHAR]`, `[WILDCHARS(n)]`, `[UNORDERED_START]`/`[UNORDERED_END]`, and `[# comment]`

Applied to files:

  • tests/wpt/runner/expectation.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: test release windows-x86_64
  • GitHub Check: test release linux-x86_64
  • GitHub Check: test debug linux-x86_64
  • GitHub Check: test debug windows-x86_64
  • GitHub Check: test debug macos-aarch64
  • GitHub Check: lint debug linux-x86_64
  • GitHub Check: lint debug windows-x86_64
  • GitHub Check: build libs
🔇 Additional comments (1)
tests/wpt/runner/expectation.json (1)

15015-15017: Marking test for skip aligns with PR objective.

The structural change from tracking a specific failure condition to using an ignore flag is appropriate for skipping this flaky test. The JSON structure looks correct.

Please confirm that { "ignore": true } is the expected format for marking tests to be ignored in this expectation file runner.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bartlomieju bartlomieju enabled auto-merge (squash) December 9, 2025 12:07
@bartlomieju bartlomieju merged commit 05dac15 into denoland:main Dec 9, 2025
32 of 37 checks passed
@bartlomieju bartlomieju deleted the ignore_flaky_wpt_test branch December 9, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants