Merged revision(s) 4491-4510, 3462-4491 from tags/version-4.8.6:

This updates the trunk with changes made in release 4.8.6.

Author: delphidabbler

Docs/ChangeLogs/ChangeLog-v4.txt

@@ -11,6 +11,10 @@
 ; Change Log for CodeSnip Release 4
 ; ------------------------------------------------------------------------------
 
+Release v4.8.6 of 28 February 2014
++ Improved operating system detection to handle Windows 8.1.
++ Added compatibility section to application manifest that declares the program has been tested with Windows Vista and Windows 7.
+
 Release v4.8.5 of 13 January 2014
 + Fixed bug #91 "Generated units won't compile on Delphi XE5" (http://bit.ly/1eBjym2). Compiler directives that are used to change compiler warnings now includes a conditionally compiled $LEGACYIFEND ON directive.
 + Fixed potential bug when checking for the existence of files. It had been possible that a "sym-link" to a file could give misleading results.

Src/3rdParty/PJSysInfo.pas

@@ -3,7 +3,7 @@
  * v. 2.0. If a copy of the MPL was not distributed with this file, You can
  * obtain one at http://mozilla.org/MPL/2.0/
  *
- * Copyright (C) 2006-2013, Peter Johnson (www.delphidabbler.com).
+ * Copyright (C) 2006-2014, Peter Johnson (www.delphidabbler.com).
  *
  * $Rev$
  * $Date$
@@ -180,7 +180,7 @@ function TBorlandCompiler.InstallPathFromReg(const RootKey: HKEY): string;
 var
   Reg: TRegistry; // registry accessor
 begin
-  if TOSInfo.CheckReportedOS(TOSInfo.WinXP) then
+  if TOSInfo.IsReallyWindowsXPOrGreater then
     Reg := TRegistry.Create(KEY_READ or KEY_WOW64_64KEY)
   else
     // KEY_WOW64_64KEY is not supported on Windows 2000

Src/Compilers.UBorland.pas

@@ -3,7 +3,7 @@
  * v. 2.0. If a copy of the MPL was not distributed with this file, You can
  * obtain one at http://mozilla.org/MPL/2.0/
  *
- * Copyright (C) 2009-2013, Peter Johnson (www.delphidabbler.com).
+ * Copyright (C) 2009-2014, Peter Johnson (www.delphidabbler.com).
  *
  * $Rev$
  * $Date$
@@ -143,7 +143,7 @@ procedure TProxyServerDlg.ConfigForm;
   TFontHelper.SetDefaultBaseFont(lblIPAddressReq.Font);
   TFontHelper.SetDefaultBaseFont(lblPortReq.Font);
   TFontHelper.SetDefaultBaseFont(lblReqSymbol.Font);
-  if TOSInfo.IsVistaOrLater then
+  if TOSInfo.IsReallyWindowsVistaOrGreater then
   begin
     edPassword1.PasswordChar := '•';
     edPassword2.PasswordChar := '•';

Src/FmProxyServerDlg.pas

@@ -5,13 +5,15 @@
  * v. 2.0. If a copy of the MPL was not distributed with this file, You can
  * obtain one at http://mozilla.org/MPL/2.0/
  *
- * Copyright (C) 2012, Peter Johnson (www.delphidabbler.com).
+ * Copyright (C) 2012-2014, Peter Johnson (www.delphidabbler.com).
  *
  * $Rev$
  * $Date$
  *
- * Manifest file specifying UI for use in XP and execution level required for
- * Vista.
+ * CodeSnip's Windows manifest file.
+ *
+ * GUIDs used in compatibility section taken from
+ * http://msdn.microsoft.com/en-us/library/windows/desktop/dn481241.aspx
 -->
 
 <assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
@@ -39,4 +41,12 @@
       </requestedPrivileges>
     </security>
   </trustInfo>
+  <compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
+    <application>
+      <!-- App has been tested on Windows 7 -->
+      <supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}"/>
+      <!-- App has been tested on Windows Vista -->
+      <supportedOS Id="{e2011457-1546-43c5-a5fe-008deee3d3f0}"/>
+    </application>
+  </compatibility>
 </assembly>

Src/Res/Misc/CodeSnip.manifest

@@ -3,7 +3,7 @@
  * v. 2.0. If a copy of the MPL was not distributed with this file, You can
  * obtain one at http://mozilla.org/MPL/2.0/
  *
- * Copyright (C) 2005-2013, Peter Johnson (www.delphidabbler.com).
+ * Copyright (C) 2005-2014, Peter Johnson (www.delphidabbler.com).
  *
  * $Rev$
  * $Date$
@@ -53,14 +53,15 @@ interface
 
   {
   TNoConstructObject:
-    Class that fails if its constructor is called. Provided as a base class for
-    classes that contain only class methods and should never be constructed.
+    Class that raises an exception if its constructor is called. Provided as a
+    base class for classes that contain only class methods and should never be
+    constructed.
   }
   TNoConstructObject = class(TObject)
   public
     constructor Create;
-      {Class constructor. Causes an assertion failure if called. The object is
-      never constructed.
+      {Prevents construction of an object instance by raising an
+      ENoConstructException if called.
       }
   end;
 
@@ -79,8 +80,8 @@   TNoPublicConstructObject = class(TObject)
       }
   public
     constructor Create;
-      {Class constructor. Causes an assertion failure if called. The object is
-      never constructed.
+      {Prevents construction of an object instance by raising an
+      ENoConstructException if called.
       }
   end;
 
@@ -100,8 +101,8 @@   TNoPublicConstructIntfObject = class(TInterfacedObject)
       }
   public
     constructor Create;
-      {Class constructor. Causes an assertion failure if called. The object is
-      never constructed.
+      {Prevents construction of an object instance by raising an
+      ENoConstructException if called.
       }
   end;
 
@@ -249,8 +250,8 @@ implementation
 { TNoConstructObject }
 
 constructor TNoConstructObject.Create;
-  {Class constructor. Causes an assertion failure if called. The object is never
-  constructed.
+  {Prevents construction of an object instance by raising an
+  ENoConstructException if called.
   }
 begin
   raise ENoConstructException.Create(
@@ -261,8 +262,8 @@ constructor TNoConstructObject.Create;
 { TNoPublicConstructObject }
 
 constructor TNoPublicConstructObject.Create;
-  {Class constructor. Causes an assertion failure if called. The object is
-  never constructed.
+  {Prevents construction of an object instance by raising an
+  ENoConstructException if called.
   }
 begin
   raise ENoConstructException.Create(
@@ -282,8 +283,8 @@ constructor TNoPublicConstructObject.InternalCreate;
 { TNoPublicConstructIntfObject }
 
 constructor TNoPublicConstructIntfObject.Create;
-  {Class constructor. Causes an assertion failure if called. The object is never
-  constructed.
+  {Prevents construction of an object instance by raising an
+  ENoConstructException if called.
   }
 begin
   raise ENoConstructException.Create(

Src/UBaseObjects.pas

@@ -3,7 +3,7 @@
  * v. 2.0. If a copy of the MPL was not distributed with this file, You can
  * obtain one at http://mozilla.org/MPL/2.0/
  *
- * Copyright (C) 2006-2013, Peter Johnson (www.delphidabbler.com).
+ * Copyright (C) 2006-2014, Peter Johnson (www.delphidabbler.com).
  *
  * $Rev$
  * $Date$
@@ -197,7 +197,7 @@ class procedure TFontHelper.SetContentFont(const Font: TFont);
   Font.Name := DefaultContentFontName;
   Font.Size := DefaultContentFontSize;
   Font.Style := [];
-  if TOSInfo.CheckReportedOS(TOSInfo.WinVista) then
+  if TOSInfo.IsReallyWindowsVistaOrGreater then
   begin
     // We have Vista or later - use Calibri if installed
     if FontExists(VistaContentFontName) then
@@ -259,7 +259,7 @@ class procedure TFontHelper.SetDefaultFont(const Font: TFont);
   Font.Name := DefaultFontName;
   Font.Size := DefaultFontSize;
   Font.Style := [];
-  if TOSInfo.CheckReportedOS(TOSInfo.WinVista) then
+  if TOSInfo.IsReallyWindowsVistaOrGreater then
   begin
     // Vista or later
     if FontExists(VistaFontName) then

Src/UFontHelper.pas

@@ -3,7 +3,7 @@
  * v. 2.0. If a copy of the MPL was not distributed with this file, You can
  * obtain one at http://mozilla.org/MPL/2.0/
  *
- * Copyright (C) 2008-2013, Peter Johnson (www.delphidabbler.com).
+ * Copyright (C) 2008-2014, Peter Johnson (www.delphidabbler.com).
  *
  * $Rev$
  * $Date$
@@ -50,6 +50,8 @@   TMarquee = class abstract(TProgressBar)
     ///  </summary>
     ///  <param name="AOwner">TComponent [in] Reference to owning component.
     ///  </param>
+    ///  <exception>ENoConstructException raised if constructor called directly
+    ///  on TMarquee instead of via sub-classes.</exception>
     ///  <remarks>This constructor must not be called directly, only by
     ///  sub-classes. Users of TMarquee must call CreateInstance instead.
     ///  </remarks>
@@ -153,7 +155,8 @@ class function TMarquee.CreateInstance(AOwner: TComponent): TMarquee;
 class function TMarquee.IsBuiltInMarqueeAvailable: Boolean;
 begin
   // We only use built in marquee on Vista or later when themes are enabled
-  Result := TOSInfo.IsVistaOrLater and ThemeServicesEx.ThemesEnabled;
+  Result := TOSInfo.IsReallyWindowsVistaOrGreater
+    and ThemeServicesEx.ThemesEnabled;
 end;
 
 { TEmulatedMarquee }