CMake Install target removed?

[hmaarrfk]

We sued to build the library with

cmake -GNinja ..
ninja install

at conda-forge but it seems like the shared library was removed in
3a3b945#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a

add_library(SafeInt INTERFACE)
target_include_directories(SafeInt INTERFACE .)
install(FILES SafeInt.hpp DESTINATION include)
install(FILES LICENSE DESTINATION share)

is there a reason this target was removed? what is the suggested way for installation today?

xref: conda-forge/safeint-feedstock#6

[dcleblanc]

I'll be able to take a look at this on the second. Sent from my T-Mobile 5G Device Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Mark Harfouche ***@***.***> Sent: Saturday, December 28, 2024 3:14:22 PM To: dcleblanc/SafeInt ***@***.***> Cc: Subscribed ***@***.***> Subject: [dcleblanc/SafeInt] CMake Install target removed? (Issue #67) We sued to build the library with cmake -GNinja .. ninja install at conda-forge but it seems like the shared library was removed in 3a3b945#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a<3a3b945#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a> add_library(SafeInt INTERFACE) target_include_directories(SafeInt INTERFACE .) install(FILES SafeInt.hpp DESTINATION include) install(FILES LICENSE DESTINATION share) is there a reason this target was removed? what is the suggested way for installation today? xref: conda-forge/safeint-feedstock#6<conda-forge/safeint-feedstock#6> — Reply to this email directly, view it on GitHub<#67>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHX6YL6IQBLACJO3SEETVBD2H3S75AVCNFSM6AAAAABUKAJEG6VHI2DSMVQWIX3LMV43ASLTON2WKOZSG43DCOBSGM2TQNI>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[hmaarrfk]

ps. i mostly just "copied in" the 3 headers of the library. I guess that is "fine".

[dcleblanc]

Hi Mark,
It looks like Egor came in and did that in 2020. I then came along some years later and nearly completely replaced the cmake files in two stages - the first because I got tired of manually going to each compiler directory and running tests via make, and the second because I'd gotten more familiar with cmake and wanted to further make the testing even easier. I don't think I ever even used Egor's check-in, so not sure what was in there.

I'd be happy to put those lines back, but I'd like to get an understanding of how they're used. Since the whole library is really just one file (two more if you count the C version), I never worried much about install as it could consist of a copy command. I normally work with huge repos and this isn't how we'd do things, so I don't have a lot of visibility into your use case.

I definitely did not intend to clobber that portion - it looks to me like I didn't really understand at the time what Egor was doing and just clean sheeted it.

[hmaarrfk]

c has never really had a good "package manager" so I understand why "installing a header only library might seem strange".

From what I've seen people tend to:

• Use git submodules.
• Manually add the "include directories"
• Move on until some version upgrade breaks their things.

A "package manager" like conda tries to centralize this process and delegate much of the complexity to others.

So even if it is a header only library, we need to install it a centralized location.

Typically, I've found that people use

install(
    SafeInt
    INCLUDES DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
)

to allow downstream packagers to override these in accordance to their requirements and preferences.

I'm happy to submit and troubleshoot a patch, but I wanted to understand the "desired usecase".

In truth, 3 copy commands aren't that hard..... so if that is the "recommended way" then the conversation can end there too.