Skip to content

Commit 54fab16

Browse files
committed
Fix workflows: Add krb5 deps and cleanup debug code
Changes across multiple workflows: 1. integration.yml: - Add krb5 system dependency to telemetry job - Fixes: krb5-config command not found error during poetry install 2. code-coverage.yml: - Add krb5 system dependency - Split telemetry tests into separate step for isolation - Maintains coverage accumulation with --cov-append 3. publish-test.yml: - Add krb5 system dependency for consistent builds 4. test_concurrent_telemetry.py: - Remove debug print statements 5. Delete test-telemetry-only.yml: - Remove temporary debug workflow All workflows now have proper telemetry test isolation and required system dependencies for kerberos packages. Signed-off-by: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent fa3cbd2 commit 54fab16

File tree

5 files changed

+36
-70
lines changed

5 files changed

+36
-70
lines changed

.github/workflows/code-coverage.yml

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,13 @@ jobs:
3131
with:
3232
python-version: "3.10"
3333
#----------------------------------------------
34+
# ----- install system dependencies -----
35+
#----------------------------------------------
36+
- name: Install system dependencies
37+
run: |
38+
sudo apt-get update
39+
sudo apt-get install -y libkrb5-dev
40+
#----------------------------------------------
3441
# ----- install & configure poetry -----
3542
#----------------------------------------------
3643
- name: Install Poetry
@@ -75,13 +82,29 @@ jobs:
7582
-v
7683
7784
#----------------------------------------------
78-
# run serial tests with coverage
85+
# run serial tests (excluding telemetry) with coverage
7986
#----------------------------------------------
80-
- name: Run serial tests with coverage
87+
- name: Run serial tests (excluding telemetry) with coverage
8188
continue-on-error: false
8289
run: |
8390
poetry run pytest tests/e2e \
8491
-m "serial" \
92+
--ignore=tests/e2e/test_telemetry_e2e.py \
93+
--ignore=tests/e2e/test_concurrent_telemetry.py \
94+
--cov=src \
95+
--cov-append \
96+
--cov-report=xml \
97+
--cov-report=term \
98+
-v
99+
100+
#----------------------------------------------
101+
# run telemetry tests with coverage (isolated)
102+
#----------------------------------------------
103+
- name: Run telemetry tests with coverage (isolated)
104+
continue-on-error: false
105+
run: |
106+
# Run telemetry tests separately for isolation
107+
poetry run pytest tests/e2e/test_concurrent_telemetry.py tests/e2e/test_telemetry_e2e.py \
85108
--cov=src \
86109
--cov-append \
87110
--cov-report=xml \

.github/workflows/integration.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,10 @@ jobs:
8080
uses: actions/setup-python@v5
8181
with:
8282
python-version: "3.10"
83+
- name: Install system dependencies
84+
run: |
85+
sudo apt-get update
86+
sudo apt-get install -y libkrb5-dev
8387
- name: Install Poetry
8488
uses: snok/install-poetry@v1
8589
with:

.github/workflows/publish-test.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,13 @@ jobs:
1616
with:
1717
python-version: 3.9
1818
#----------------------------------------------
19+
# ----- install system dependencies -----
20+
#----------------------------------------------
21+
- name: Install system dependencies
22+
run: |
23+
sudo apt-get update
24+
sudo apt-get install -y libkrb5-dev
25+
#----------------------------------------------
1926
# ----- install & configure poetry -----
2027
#----------------------------------------------
2128
- name: Install Poetry

.github/workflows/test-telemetry-only.yml

Lines changed: 0 additions & 57 deletions
This file was deleted.

tests/e2e/test_concurrent_telemetry.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -163,17 +163,6 @@ def execute_query_worker(thread_id):
163163
if "numProtoSuccess" in response:
164164
total_successful_events += response["numProtoSuccess"]
165165

166-
# DEBUG: Print detailed counts to understand CI vs local difference
167-
print(f"\n{'='*60}")
168-
print(f"TELEMETRY DEBUG - Understanding 88 vs 60 discrepancy")
169-
print(f"{'='*60}")
170-
print(f"Client side captured_telemetry: {len(captured_telemetry)} events")
171-
print(f"Client side captured_futures: {len(captured_futures)} futures")
172-
print(f"Server side captured_responses: {len(captured_responses)} responses")
173-
print(f"Server reported total_successful_events: {total_successful_events}")
174-
print(f"Expected events: {num_threads * 2}")
175-
print(f"{'='*60}\n")
176-
177166
assert total_successful_events == num_threads * 2
178167

179168
assert (

0 commit comments

Comments
 (0)