Commit 471a551
committed
Address review comments: revert timeout and telemetry_enabled changes
Per reviewer feedback on PR #734:
1. Revert timeout from 30s back to 900s (line 299)
- Reviewer noted that with wait=False, timeout is not critical
- The async nature and wait=False handle the exit speed
2. Revert telemetry_enabled parameter back to True (line 734)
- Reviewer noted this is redundant given the early return
- If enable_telemetry=False, we return early (line 729)
- Line 734 only executes when enable_telemetry=True
- Therefore using the parameter here is unnecessary
These changes address the reviewer's valid technical concerns while
keeping the core fixes intact:
- wait=False for non-blocking shutdown (critical for Issue #729)
- Early return when enable_telemetry=False (critical for Issue #729)
- All Issue #731 fixes (null-safety, __del__, documentation)
Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>1 parent bcdc8a5 commit 471a551
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
296 | 296 | | |
297 | 297 | | |
298 | 298 | | |
299 | | - | |
| 299 | + | |
300 | 300 | | |
301 | 301 | | |
302 | 302 | | |
| |||
731 | 731 | | |
732 | 732 | | |
733 | 733 | | |
734 | | - | |
| 734 | + | |
735 | 735 | | |
736 | 736 | | |
737 | 737 | | |
| |||
0 commit comments