Skip to content

Commit 2a85688

Browse files
committed
Remove unnecessary _retry_server_directed_only instance variables
Inline kwargs.get() at the single point of use in ThriftDatabricksClient and SeaHttpClient instead of storing as dead instance state. Signed-off-by: Shubham Dhal <shubham.dhal@databricks.com>
1 parent df75ba1 commit 2a85688

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

src/databricks/sql/backend/sea/utils/http_client.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,6 @@ def __init__(
9090
)
9191
self._retry_delay_default = kwargs.get("_retry_delay_default", 5.0)
9292
self.force_dangerous_codes = kwargs.get("_retry_dangerous_codes", [])
93-
self._retry_server_directed_only = kwargs.get(
94-
"_retry_server_directed_only", False
95-
)
9693

9794
# Connection pooling settings
9895
self.max_connections = kwargs.get("max_connections", 10)
@@ -117,7 +114,7 @@ def __init__(
117114
stop_after_attempts_duration=self._retry_stop_after_attempts_duration,
118115
delay_default=self._retry_delay_default,
119116
force_dangerous_codes=self.force_dangerous_codes,
120-
server_directed_only=self._retry_server_directed_only,
117+
server_directed_only=kwargs.get("_retry_server_directed_only", False),
121118
urllib3_kwargs=urllib3_kwargs,
122119
)
123120
else:

src/databricks/sql/backend/thrift_backend.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -189,9 +189,6 @@ def __init__(
189189
" This behaviour is deprecated and will be removed in a future release."
190190
)
191191
self.force_dangerous_codes = kwargs.get("_retry_dangerous_codes", [])
192-
self._retry_server_directed_only = kwargs.get(
193-
"_retry_server_directed_only", False
194-
)
195192

196193
additional_transport_args = {}
197194

@@ -218,7 +215,7 @@ def __init__(
218215
stop_after_attempts_duration=self._retry_stop_after_attempts_duration,
219216
delay_default=self._retry_delay_default,
220217
force_dangerous_codes=self.force_dangerous_codes,
221-
server_directed_only=self._retry_server_directed_only,
218+
server_directed_only=kwargs.get("_retry_server_directed_only", False),
222219
urllib3_kwargs=urllib3_kwargs,
223220
)
224221

0 commit comments

Comments
 (0)