Skip to content

Commit 0d583fa

Browse files
committed
Remove unnecessary _retry_server_directed_only instance variables
Inline kwargs.get() at the single point of use in ThriftDatabricksClient and SeaHttpClient instead of storing as dead instance state. Signed-off-by: Shubham Dhal <shubham.dhal@databricks.com>
1 parent 179140a commit 0d583fa

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

src/databricks/sql/backend/sea/utils/http_client.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,6 @@ def __init__(
9292
)
9393
self._retry_delay_default = kwargs.get("_retry_delay_default", 5.0)
9494
self.force_dangerous_codes = kwargs.get("_retry_dangerous_codes", [])
95-
self._retry_server_directed_only = kwargs.get(
96-
"_retry_server_directed_only", False
97-
)
9895

9996
# Connection pooling settings
10097
self.max_connections = kwargs.get("max_connections", 10)
@@ -119,7 +116,7 @@ def __init__(
119116
stop_after_attempts_duration=self._retry_stop_after_attempts_duration,
120117
delay_default=self._retry_delay_default,
121118
force_dangerous_codes=self.force_dangerous_codes,
122-
server_directed_only=self._retry_server_directed_only,
119+
server_directed_only=kwargs.get("_retry_server_directed_only", False),
123120
urllib3_kwargs=urllib3_kwargs,
124121
)
125122
else:

src/databricks/sql/backend/thrift_backend.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -191,9 +191,6 @@ def __init__(
191191
" This behaviour is deprecated and will be removed in a future release."
192192
)
193193
self.force_dangerous_codes = kwargs.get("_retry_dangerous_codes", [])
194-
self._retry_server_directed_only = kwargs.get(
195-
"_retry_server_directed_only", False
196-
)
197194

198195
additional_transport_args = {}
199196

@@ -220,7 +217,7 @@ def __init__(
220217
stop_after_attempts_duration=self._retry_stop_after_attempts_duration,
221218
delay_default=self._retry_delay_default,
222219
force_dangerous_codes=self.force_dangerous_codes,
223-
server_directed_only=self._retry_server_directed_only,
220+
server_directed_only=kwargs.get("_retry_server_directed_only", False),
224221
urllib3_kwargs=urllib3_kwargs,
225222
)
226223

0 commit comments

Comments
 (0)