Commit cb264ab
committed
Fix empty/whitespace azureTenantId falling through to malformed URL
??-coalescing only substitutes for null/undefined, so an empty or
whitespace-only azureTenantId would build
`https://login.microsoftonline.com//v2.0/...` (double slash) and surface
as an opaque Azure 404. Trim first and use || so any falsy/blank value
falls back to /organizations/ like the unset case.
Co-authored-by: Isaac1 parent f3fdcde commit cb264ab
2 files changed
Lines changed: 11 additions & 1 deletion
File tree
- lib/connection/auth/DatabricksOAuth
- tests/unit/connection/auth/DatabricksOAuth
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
277 | 277 | | |
278 | 278 | | |
279 | 279 | | |
280 | | - | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
281 | 283 | | |
282 | 284 | | |
283 | 285 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
547 | 547 | | |
548 | 548 | | |
549 | 549 | | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
550 | 558 | | |
551 | 559 | | |
552 | 560 | | |
| |||
0 commit comments