Skip to content

Commit bff8d0d

Browse files
style: prettier --write on review-fixup files
Auto-formatting after the previous review fixups commit. CONTRIBUTING.md list-item indentation, ArrowResultConverter.test.ts multi-line throw collapsed to one line, thrift-field-id-validation.test.ts same. Co-authored-by: Isaac Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
1 parent 69c81f9 commit bff8d0d

3 files changed

Lines changed: 3 additions & 6 deletions

File tree

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ npm run type-check
112112
A few entries in `package.json` are pinned more tightly than usual. Don't relax these without understanding why.
113113

114114
- **`typescript: "5.5.4"`** (exact, no caret). This pin has both a floor and a ceiling:
115+
115116
- Floor (TS >= 5.0) is required because `uuid@11`'s shipped `.d.ts` uses `export type * from './types.js'`, a TS 5.0+ feature.
116117
- Ceiling (TS < 5.6) is required because TS 5.6 changed how `@types/node`'s generic `Buffer<TArrayBuffer extends ArrayBufferLike>` declarations get emitted into our published `dist/*.d.ts`. Allowing TS 5.6+ would leak `Buffer<ArrayBufferLike>` into the published types, which fails to compile for consumers on stale `@types/node`.
117118
- If you bump TS, run `npm run build` and `git diff dist/` and verify no `Buffer<...>` generics appear in any `.d.ts`. If they do, you need to either roll back or also bump `@types/node` consumer expectations (a customer-facing change).

tests/unit/result/ArrowResultConverter.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,7 @@ const sampleArrowBatch = [
6161
// import time, so a wrong CWD must fail clearly rather than producing
6262
// an opaque ENOENT.
6363
if (!fs.existsSync('package.json')) {
64-
throw new Error(
65-
`Expected mocha to be invoked from repo root; CWD=${process.cwd()} has no package.json`,
66-
);
64+
throw new Error(`Expected mocha to be invoked from repo root; CWD=${process.cwd()} has no package.json`);
6765
}
6866
const ARROW_STUBS_DIR = path.resolve('tests/unit/result/.stubs');
6967
const arrowBatchAllNulls = [

tests/unit/thrift-field-id-validation.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@ describe('Thrift Field ID Validation', () => {
2020
// file is executed from a non-repo-root CWD (e.g. running a single
2121
// spec from a subdirectory) instead of producing an opaque ENOENT.
2222
if (!fs.existsSync('package.json')) {
23-
throw new Error(
24-
`Expected mocha to be invoked from repo root; CWD=${process.cwd()} has no package.json`,
25-
);
23+
throw new Error(`Expected mocha to be invoked from repo root; CWD=${process.cwd()} has no package.json`);
2624
}
2725
});
2826

0 commit comments

Comments
 (0)