Commit 4427d4d
committed
test(sea): F4 round-3 — inline-result-set (SELECT 1) edge case
DA F4 round-1 M1 finding (partial): the existing 5 fetch-all e2e
cases (range(0,100) row-count, range(0,0) empty, multi-column,
drain-twice, drain-after-close) all flow through the row-set
generator path. A literal `SELECT 1` returns a single inline
batch and exercises a distinct code path inside
SeaOperationBackend.fetchChunk → ResultSlicer → ArrowResultConverter
that the other 5 do not.
One new `it()` block:
- Open session, execute `SELECT 1 AS x`, drain via `fetchAll()`.
- Assert array of length 1; row has property `x` with non-null,
non-undefined value. Type pinning is deliberately loose so the
test stays forward-compatible with converter promotion changes;
the load-bearing assertion is the single-row inline-batch drain.
Drop-in form follows DA's round-3 snippet verbatim (modulo the
loosened type pin per the comment above).
Gates (touched file only):
- `node_modules/.bin/eslint tests/e2e/sea/fetch-all-e2e.test.ts`
EXIT=0, zero errors.
- `node_modules/.bin/tsc --noEmit` baseline 21 → current 21
(delta 0; the only error in the touched file is a pre-existing
`import.meta` issue at line 57 carried over from the F4 round-1
H1 fix — not touched by this commit).
Live e2e against pecotesting via `TS_NODE_TRANSPILE_ONLY=true yarn
e2e tests/e2e/sea/fetch-all-e2e.test.ts`:
6/6 passing in 4s, with the new test landing at 445ms.
Closes the round-3 F4-M1 audit item; F3-M3 closed in 9f1a967;
matrix scope-down landed by team-lead on PR #77 (dfea75a).
Co-authored-by: Isaac
Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>1 parent 9f1a967 commit 4427d4d
1 file changed
Lines changed: 37 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
258 | 258 | | |
259 | 259 | | |
260 | 260 | | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
261 | 298 | | |
0 commit comments