Skip to content

Commit 3156569

Browse files
ci: use underscore in E2E_TABLE_SUFFIX node prefix, not hyphen
E2E tests build SQL identifiers as `..._${E2E_TABLE_SUFFIX}`. Hyphens aren't valid in unquoted SQL identifiers, so the previous `-node${matrix.node-version}` suffix caused all e2e jobs to fail with INVALID_IDENTIFIER (SQLSTATE 42602): DROP TABLE IF EXISTS dbsql_nodejs_sdk_e2e_interval_types_<sha>-node20 ^ Use `_node<version>` instead. The underscore keeps identifiers valid across all matrix entries. Co-authored-by: Isaac Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
1 parent a440860 commit 3156569

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/main.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,8 +211,10 @@ jobs:
211211
E2E_PATH: ${{ secrets.TEST_PECO_WAREHOUSE_HTTP_PATH }}
212212
E2E_ACCESS_TOKEN: ${{ secrets.DATABRICKS_TOKEN }}
213213
# Include Node version in the suffix so parallel matrix entries
214-
# don't collide on shared E2E table names.
215-
E2E_TABLE_SUFFIX: ${{ github.sha }}-node${{ matrix.node-version }}
214+
# don't collide on shared E2E table names. Use underscore (not
215+
# hyphen) — hyphens aren't valid in SQL unquoted identifiers,
216+
# and tests build identifiers as `..._${E2E_TABLE_SUFFIX}`.
217+
E2E_TABLE_SUFFIX: ${{ github.sha }}_node${{ matrix.node-version }}
216218
E2E_CATALOG: peco
217219
E2E_SCHEMA: default
218220
E2E_VOLUME: e2etests

0 commit comments

Comments
 (0)