Fix SEA abstraction merge fallout

Restore Thrift compatibility paths needed by existing schema and result-handler tests after merging main telemetry changes.

Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>

Author: msrathore-db

lib/DBSQLOperation.ts

@@ -9,11 +9,7 @@ import IOperation, {
   IOperationRowsIterator,
   NodeStreamOptions,
 } from './contracts/IOperation';
-import {
-  TGetOperationStatusResp,
-  TGetResultSetMetadataResp,
-  TTableSchema,
-} from '../thrift/TCLIService_types';
+import { TGetOperationStatusResp, TGetResultSetMetadataResp, TTableSchema } from '../thrift/TCLIService_types';
 import Status from './dto/Status';
 import { LogLevel } from './contracts/IDBSQLLogger';
 import OperationStateError, { OperationStateErrorCode } from './errors/OperationStateError';
@@ -270,11 +266,28 @@ export default class DBSQLOperation implements IOperation {
       await this.waitUntilReadyThroughBackend(options);
 
       this.context.getLogger().log(LogLevel.debug, `Fetching schema for operation with id: ${this.id}`);
+      if (this.backend instanceof ThriftOperationBackend) {
+        const metadata = await this.backend.thriftResultMetadataResponse();
+        return metadata.schema ?? null;
+      }
       const metadata = await this.getResultMetadata();
       return metadata.schema ?? null;
     });
   }
 
+  /**
+   * Thrift-only compatibility hook used by existing e2e tests to assert the
+   * concrete result handler selected for a result format.
+   *
+   * Not part of the public `IOperation` contract.
+   */
+  public async getResultHandler(): Promise<unknown> {
+    if (this.backend instanceof ThriftOperationBackend) {
+      return this.backend.getResultHandler();
+    }
+    throw new Error('DBSQLOperation.getResultHandler is only available for the Thrift backend');
+  }
+
   public async getResultMetadata(): Promise<ResultMetadata> {
     await this.failIfClosed();
     await this.waitUntilReadyThroughBackend();

lib/contracts/IOperationBackend.ts

@@ -61,11 +61,7 @@ export default interface IOperationBackend {
    * returning `[]` is the correct way to bail — the user-visible error is
    * still raised by the facade.
    */
-  fetchChunk(options: {
-    limit: number;
-    disableBuffering?: boolean;
-    isClosed?: () => boolean;
-  }): Promise<Array<object>>;
+  fetchChunk(options: { limit: number; disableBuffering?: boolean; isClosed?: () => boolean }): Promise<Array<object>>;
 
   /** Whether more rows are available beyond what has been fetched. */
   hasMore(): Promise<boolean>;

lib/thrift-backend/ThriftOperationBackend.ts

@@ -314,7 +314,7 @@ export default class ThriftOperationBackend implements IOperationBackend {
     return new Status(response.status);
   }
 
-  private async getResultHandler(): Promise<ResultSlicer<any>> {
+  public async getResultHandler(): Promise<ResultSlicer<any>> {
     const metadata = await this.thriftResultMetadataResponse();
     const resultFormat = definedOrError(metadata.resultFormat);
 

tests/unit/.stubs/createOperationForTest.ts

@@ -15,11 +15,7 @@ interface CreateOperationForTestArgs {
  * shape by constructing a `ThriftOperationBackend` explicitly. Keeps the
  * facade decoupled from concrete backend imports.
  */
-export function createOperationForTest({
-  handle,
-  directResults,
-  context,
-}: CreateOperationForTestArgs): DBSQLOperation {
+export function createOperationForTest({ handle, directResults, context }: CreateOperationForTestArgs): DBSQLOperation {
   const backend = new ThriftOperationBackend({ handle, directResults, context });
   return new DBSQLOperation({ backend, context });
 }

tests/unit/.stubs/createSessionForTest.ts

@@ -15,7 +15,11 @@ interface CreateSessionForTestArgs {
  * shape by constructing a `ThriftSessionBackend` explicitly. Keeps the
  * facade decoupled from concrete backend imports.
  */
-export function createSessionForTest({ handle, context, serverProtocolVersion }: CreateSessionForTestArgs): DBSQLSession {
+export function createSessionForTest({
+  handle,
+  context,
+  serverProtocolVersion,
+}: CreateSessionForTestArgs): DBSQLSession {
   const backend = new ThriftSessionBackend({ handle, context, serverProtocolVersion });
   return new DBSQLSession({ backend, context });
 }

tests/unit/thrift-backend/wireSynthesis.test.ts

@@ -1,15 +1,8 @@
 import { expect } from 'chai';
-import {
-  TOperationState,
-  TSparkRowSetType,
-  TStatusCode,
-} from '../../../thrift/TCLIService_types';
+import { TOperationState, TSparkRowSetType, TStatusCode } from '../../../thrift/TCLIService_types';
 import { OperationState, OperationStatus } from '../../../lib/contracts/OperationStatus';
 import { ResultFormat, ResultMetadata } from '../../../lib/contracts/ResultMetadata';
-import {
-  synthesizeThriftStatus,
-  synthesizeThriftResultSetMetadata,
-} from '../../../lib/thrift-backend/wireSynthesis';
+import { synthesizeThriftStatus, synthesizeThriftResultSetMetadata } from '../../../lib/thrift-backend/wireSynthesis';
 import HiveDriverError from '../../../lib/errors/HiveDriverError';
 
 describe('wireSynthesis', () => {
@@ -90,9 +83,9 @@ describe('wireSynthesis', () => {
       expect(
         synthesizeThriftResultSetMetadata({ ...base, resultFormat: ResultFormat.ArrowBased }).resultFormat,
       ).to.equal(TSparkRowSetType.ARROW_BASED_SET);
-      expect(
-        synthesizeThriftResultSetMetadata({ ...base, resultFormat: ResultFormat.UrlBased }).resultFormat,
-      ).to.equal(TSparkRowSetType.URL_BASED_SET);
+      expect(synthesizeThriftResultSetMetadata({ ...base, resultFormat: ResultFormat.UrlBased }).resultFormat).to.equal(
+        TSparkRowSetType.URL_BASED_SET,
+      );
     });
 
     it('throws HiveDriverError on an unknown ResultFormat instead of silently aliasing', () => {