Skip to content

Commit 05001b7

Browse files
committed
telemetry: restrict driver_connection_params to proto-defined fields
Drop four Node-specific fields that aren't in the receiver's `DriverConnectionParameters` proto schema: - cloud_fetch_enabled - lz4_enabled - retry_max_attempts - cloud_fetch_concurrent_downloads These would be ignored at deserialization on the receiver side anyway. Remaining block contains only proto-defined fields: `host_info`, `http_path`, `enable_arrow`, `enable_direct_results`, `socket_timeout`, `enable_metric_view_metadata`. Co-authored-by: Isaac
1 parent b10a592 commit 05001b7

1 file changed

Lines changed: 0 additions & 8 deletions

File tree

lib/telemetry/DatabricksTelemetryExporter.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,6 @@ interface DatabricksTelemetryLog {
6868
enable_direct_results?: boolean;
6969
socket_timeout?: number;
7070
enable_metric_view_metadata?: boolean;
71-
cloud_fetch_enabled?: boolean;
72-
lz4_enabled?: boolean;
73-
retry_max_attempts?: number;
74-
cloud_fetch_concurrent_downloads?: number;
7571
};
7672
operation_latency_ms?: number;
7773
sql_operation?: {
@@ -419,10 +415,6 @@ export default class DatabricksTelemetryExporter {
419415
enable_direct_results: metric.driverConfig.directResultsEnabled,
420416
socket_timeout: metric.driverConfig.socketTimeout,
421417
enable_metric_view_metadata: metric.driverConfig.enableMetricViewMetadata,
422-
cloud_fetch_enabled: metric.driverConfig.cloudFetchEnabled,
423-
lz4_enabled: metric.driverConfig.lz4Enabled,
424-
retry_max_attempts: metric.driverConfig.retryMaxAttempts,
425-
cloud_fetch_concurrent_downloads: metric.driverConfig.cloudFetchConcurrentDownloads,
426418
};
427419
}
428420
} else if (metric.metricType === 'statement') {

0 commit comments

Comments
 (0)