Mobile comment pre-fill not working

[rebelchris]

On mobile the notification doesn't seem to link properly.
Please read comment in this thread as they describe the issue: dailydotdev/daily#1245

[rebelchris]

@claude give it a go

[claude]

Claude finished @rebelchris's task in 5m 48s —— View job • claude/issue-5296-20260114-0710 • Create PR ➔

---

Mobile comment pre-fill fix completed ✓

Todo List

• Read referenced issue fix: change email #1245 to understand the problem
• Search for comment pre-fill logic in codebase
• Identify the mobile-specific bug
• Implement the fix
• Run linter to verify code quality
• Commit and push changes
• Provide PR link

Issue Found

The bug was in packages/shared/src/components/post/NewComment.tsx:82-100. The component only handled the ?comment= query parameter for PostType.Welcome and PostType.Poll, but ignored it for regular article posts. This meant notifications linking to article posts with pre-filled comment text wouldn't work on mobile.

Fix Applied

Removed the post type restriction so comment pre-fill now works for all post types:

• Article
• Share
• VideoYouTube
• Brief
• Freeform
• Collection
• Welcome (already working)
• Poll (already working)

The fix also properly determines the origin based on the post type for better analytics tracking.

Changes

• Modified packages/shared/src/components/post/NewComment.tsx
• Replaced nested ternary with if/else for better readability
• Lint passed successfully

---

| Branch

[rebelchris]

@claude I'm not sure that's fully right the original issue mentions it's for welcome post.
He says it works on desktop, but not on mobile.

I think we should keep the constraints as where, but see why on mobile it behaves differently.

[claude]

Claude finished @rebelchris's task in 5m 51s —— View job • claude/issue-5296-20260114-0723 • Create PR ➔

---

Mobile comment pre-fill bug fixed ✓

Todo List

• Read referenced issue fix: change email #1245 to understand the original problem
• Review current code structure
• Investigate mobile vs desktop behavior differences
• Identify the actual mobile-specific bug
• Implement the correct fix
• Run linter to verify code quality
• Commit and push changes

Root Cause

You were absolutely right - the issue is mobile-specific for Welcome posts, not about missing post types.

The Problem: On mobile, there are TWO NewComment components rendered:

1. From PostEngagements (via BasePostContent):

   • Located in the post content area
   • Has shouldHandleCommentQuery={true} ✓
   • Handles the ?comment= query parameter correctly

2. From FooterWrapper (mobile footer):

   • packages/webapp/components/footer/FooterWrapper.tsx:57-69
   • Only renders on mobile (tablet:hidden)
   • Was missing shouldHandleCommentQuery prop! ✗
   • This is the one users actually interact with on mobile

Why desktop works: Desktop only has the PostEngagements version which has shouldHandleCommentQuery.

Why mobile failed: Users click the footer comment button, which didn't know about the pre-fill query parameter.

The Fix

Added shouldHandleCommentQuery prop to the footer's NewComment component in FooterWrapper.tsx:67.

This one-line change enables the mobile footer comment button to handle notification links with pre-filled comment text, just like it works on desktop.

Changes

• Modified packages/webapp/components/footer/FooterWrapper.tsx
• Linter passed successfully
• Committed with detailed explanation

---