Broken links

[DDuran19]

• /search - when clicking on a user on the list, it routes to a /profile/username, must be /[username]. Can we make this a modal instead?
• /[username] - the mailto: link does not have proper name it's just "@" and there's no prompt or any visual indicator what it will do. It opens up email which might hurt UX.
  

[devpapi0891]

(/search - when clicking on a user on the list, it routes to a /profile/username, must be /[username]. Can we make this a modal instead?)

I think it was made that way to optimize SEO when a URL or username is shared on social media. I agree with making it a modal, but perhaps we could use shallow routing so that SEO still works?

[DDuran19]

I think that's a good idea. Do you already know how to implement it?

I think it was made that way to optimize SEO when a URL or username is shared on social media. I agree with making it a modal, but perhaps we could use shallow routing so that SEO still works?

[directormac]

Shallow route would be good there too, clicking the link pushes to the page state and render a modal.

[DDuran19]

I already fixed the broken links indicated in the issue description. Except for this modal thing, if you could implement it that'd be great, I already started the PR for this issue

[directormac]

The links from #207 ? I asked @os-hi about it i think he prefer those links to be on the #events or something as he was doing the part on the smooth scroll afair.

[DDuran19]

It's a different issue, the #207 links are not broken and is working, but the links on this issue literally doesn't

[directormac]

Ahh i see it's referring to the /search i thought this was from the /team page. I thought you fixed this issue when on your last pr, because before the /search page just had a dummy functionality i think it was #204.