Skip to content

Commit 5a1be07

Browse files
Sniderclaude
andcommitted
fix(static-analysis): drop missing src/Core/Service/Tests path, suppress pending Service module
PHPStan + Psalm CI both failed at config-load on #2 because src/Core/Service/Tests doesn't exist. Removed that exclude entry from both configs. Knock-on: BunnyStorageService implements Core\Service\Contracts\HealthCheckable which lives in a not-yet-built Core\Service module. PHPStan flagged it via non-ignorable interface.notFound, Psalm via MissingDependency. Excluded the file from PHPStan and added directory-scoped MissingDependency suppression to Psalm covering src/Core/Cdn until the Service module lands. Also added Front\Client\Boot to the UndefinedClass suppression list (pending Front\Client frontage subpackage). Local verification: vendor/bin/phpstan analyse --no-progress → No errors vendor/bin/psalm --no-progress → No errors found composer test → 245 tests pass Tracked under core/lint RFC migration: plans/code/core/lint/RFC.md Co-Authored-By: Cladius Maximus <claude@anthropic.com>
1 parent d2410f5 commit 5a1be07

2 files changed

Lines changed: 14 additions & 2 deletions

File tree

phpstan.neon

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ parameters:
1717
- src/Core/Tests
1818
- src/Core/Bouncer/Tests
1919
- src/Core/Bouncer/Gate/Tests
20-
- src/Core/Service/Tests
2120
- src/Core/Front/Tests
2221
- src/Mod/Trees
22+
# Pending Core\Service module — see plans/code/core/lint/RFC.md migration
23+
- src/Core/Cdn/Services/BunnyStorageService.php
2324
reportUnmatchedIgnoredErrors: false

psalm.xml

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,21 @@
5555
<referencedClass name="Core\Tenant\Models\User" />
5656
<referencedClass name="Core\Tenant\Services\EntitlementService" />
5757
<referencedClass name="Core\Config\Workspace" />
58+
<!-- Pending Core\Service module (see plans/code/core/lint/RFC.md) -->
59+
<referencedClass name="Core\Service\Contracts\HealthCheckable" />
60+
<referencedClass name="Core\Service\HealthCheckResult" />
61+
<!-- Pending Front\Client frontage subpackage -->
62+
<referencedClass name="Core\Front\Client\Boot" />
5863
</errorLevel>
5964
</UndefinedClass>
6065

66+
<!-- Pending Core\Service module — referenced by Cdn BunnyStorageService and app variant -->
67+
<MissingDependency>
68+
<errorLevel type="suppress">
69+
<directory name="src/Core/Cdn" />
70+
</errorLevel>
71+
</MissingDependency>
72+
6173
<!-- Suppress false positives from strict type analysis -->
6274
<NoValue>
6375
<errorLevel type="suppress">
@@ -82,7 +94,6 @@
8294
<directory name="src/Core/Input/Tests" />
8395
<directory name="src/Core/Bouncer/Tests" />
8496
<directory name="src/Core/Bouncer/Gate/Tests" />
85-
<directory name="src/Core/Service/Tests" />
8697
<directory name="src/Core/Front/Tests" />
8798
<directory name="src/Mod/Trees" />
8899
</ignoreFiles>

0 commit comments

Comments
 (0)