Stream.measures(): collect MetronomeMark by default#1895
Merged
mscuthbert merged 5 commits intoMay 16, 2026
Conversation
mscuthbert
reviewed
May 16, 2026
| meter.TimeSignature, | ||
| instrument.Instrument, | ||
| key.KeySignature, | ||
| tempo.MetronomeMark |
Member
There was a problem hiding this comment.
when each has its own line, we do comma dangle. when in line (as above) we don't
Member
|
i'm +1 on this. the PR demos that collect should eventually be typed and listed (as classes not strings) in one place (as defaultCollect) but do that later. Get the tests fixed in ASAP and it'll make the next release (today) |
|
coverage: 93.067%. remained the same — oxygen-dioxide:collect-metronomemark into cuthbertLab:master |
Member
|
Thanks! |
Member
|
ah -- i did complete the release before bed last night -- i'll make a 10.1.1 tomorrow or the next day. this is good to get in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 'MetronomeMark' to the default collect tuple in Stream.measures().
Motivation
When extracting a region of measures via measures(), the method collects context elements (Clef, TimeSignature, Instrument, KeySignature, etc.) from the surrounding stream so the excerpt is self-contained and playable. However, MetronomeMark was missing from the default collection list.
This means if a tempo indication (e.g. MetronomeMark(number=80)) appears before the extracted region but not inside it, the excerpt will have no tempo marking, causing playback to fall back to a default tempo (often 120 quarter notes per minute in music21's default, but missing the actual intended tempo). Adding 'MetronomeMark' ensures the most recent tempo marking is preserved in the extracted excerpt, matching the behavior of the other context elements already collected.