Skip to content

Commit 5cde7d3

Browse files
authored
Tweak GitHub Actions workflows (#2)
- Add validation job - More consistent spacing and ordering - Remove unnecessary release permissions
1 parent e293ab7 commit 5cde7d3

2 files changed

Lines changed: 19 additions & 5 deletions

File tree

.github/workflows/release.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,17 @@ jobs:
1010
name: "Release to GHCR"
1111
if: ${{ github.ref == 'refs/heads/main' }}
1212
runs-on: ubuntu-latest
13+
1314
permissions:
14-
contents: write
15-
pull-requests: write
1615
packages: write
16+
1717
steps:
1818
- uses: actions/checkout@v6
1919

2020
- name: "Publish features"
2121
uses: devcontainers/action@v1
22+
env:
23+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2224
with:
2325
publish-features: "true"
2426
base-path-to-features: "./src"
25-
env:
26-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/test.yaml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ on:
55
branches:
66
- main
77
pull_request:
8-
workflow_dispatch:
98

109
jobs:
1110
docs:
1211
name: "Ensure documentation has been generated"
1312
runs-on: ubuntu-latest
13+
1414
steps:
1515
- uses: actions/checkout@v6
1616

@@ -26,12 +26,26 @@ jobs:
2626
shellcheck:
2727
name: Shellcheck
2828
runs-on: ubuntu-latest
29+
2930
steps:
3031
- uses: actions/checkout@v6
3132

3233
- name: Run ShellCheck
3334
uses: ludeeus/action-shellcheck@2.0.0
3435

36+
validate:
37+
runs-on: ubuntu-latest
38+
39+
steps:
40+
- name: Checkout
41+
uses: actions/checkout@v6
42+
43+
- name: Validate devcontainer-feature.json files
44+
uses: devcontainers/action@v1
45+
with:
46+
validate-only: "true"
47+
base-path-to-features: ./src
48+
3549
test:
3650
name: "Test ${{ matrix.feature }} on ${{ matrix.baseImage }}"
3751
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)