move logger to module level

Author: Kareem Zidane

src/cs50/sql.py

@@ -1,3 +1,24 @@
+import logging
+
+from .cs50 import _formatException
+
+
+# Configure logger
+_logger = logging.getLogger(__name__)
+_logger.setLevel(logging.DEBUG)
+
+# Log messages once
+_logger.propagate = False
+
+ch = logging.StreamHandler()
+ch.setLevel(logging.DEBUG)
+
+formatter = logging.Formatter("%(levelname)s: %(message)s")
+formatter.formatException = lambda exc_info: _formatException(*exc_info)
+ch.setFormatter(formatter)
+_logger.addHandler(ch)
+
+
 class SQL(object):
     """Wrap SQLAlchemy to provide a simple SQL API."""
 
@@ -12,14 +33,11 @@ def __init__(self, url, **kwargs):
         """
 
         # Lazily import
-        import logging
         import os
         import re
         import sqlalchemy
         import sqlite3
 
-        from .cs50 import _formatException
-
         # Require that file already exist for SQLite
         matches = re.search(r"^sqlite:///(.+)$", url)
         if matches:
@@ -50,32 +68,18 @@ def connect(dbapi_connection, connection_record):
         # Register listener
         sqlalchemy.event.listen(self._engine, "connect", connect)
 
-        # Configure logger
-        self._logger = logging.getLogger(__name__)
-        self._logger.setLevel(logging.DEBUG)
-
-        # Log messages once
-        self._logger.propagate = False
-
-        ch = logging.StreamHandler()
-        ch.setLevel(logging.DEBUG)
-
-        formatter = logging.Formatter("%(levelname)s: %(message)s")
-        formatter.formatException = lambda exc_info: _formatException(*exc_info)
-        ch.setFormatter(formatter)
-        self._logger.addHandler(ch)
 
         # Test database
-        disabled = self._logger.disabled
-        self._logger.disabled = True
+        disabled = _logger.disabled
+        _logger.disabled = True
         try:
             self.execute("SELECT 1")
         except sqlalchemy.exc.OperationalError as e:
             e = RuntimeError(_parse_exception(e))
             e.__cause__ = None
             raise e
         finally:
-            self._logger.disabled = disabled
+            _logger.disabled = disabled
 
     def __del__(self):
         """Disconnect from database."""
@@ -356,22 +360,22 @@ def shutdown_session(exception=None):
 
             # If constraint violated, return None
             except sqlalchemy.exc.IntegrityError as e:
-                self._logger.debug(termcolor.colored(statement, "yellow"))
+                _logger.debug(termcolor.colored(statement, "yellow"))
                 e = ValueError(e.orig)
                 e.__cause__ = None
                 raise e
 
             # If user error
             except (sqlalchemy.exc.OperationalError, sqlalchemy.exc.ProgrammingError) as e:
                 self._disconnect()
-                self._logger.debug(termcolor.colored(statement, "red"))
+                _logger.debug(termcolor.colored(statement, "red"))
                 e = RuntimeError(e.orig)
                 e.__cause__ = None
                 raise e
 
             # Return value
             else:
-                self._logger.debug(termcolor.colored(_statement, "green"))
+                _logger.debug(termcolor.colored(_statement, "green"))
                 return ret
 
     def _escape(self, value):