Hi there,
while working on crate/crate-python#391, some backlog items have accumulated. I will gather them within this ticket.
Internals
We've identified a few shortcomings in the internal implementation of the CrateDB SQLAlchemy dialect. While it seems to work in general, those spots can well be improved, in order to better align with the internal API hooks of SQLAlchemy, and how the CrateDB dialect interacts with that.
More
With kind regards,
Andreas.
Hi there,
while working on crate/crate-python#391, some backlog items have accumulated. I will gather them within this ticket.
Internals
We've identified a few shortcomings in the internal implementation of the CrateDB SQLAlchemy dialect. While it seems to work in general, those spots can well be improved, in order to better align with the internal API hooks of SQLAlchemy, and how the CrateDB dialect interacts with that.
before_executeevent.Mike Bayer advised us to hook into
ExecutionContext.pre_exec()for rewritingUPDATEstatements instead of using any kinds of engine- or dialect-events, like our current implementation.Discussions:
- Add support for SQLAlchemy 1.4 crate-python#391 (comment)
- Making the CrateDB dialect compatible with SQLAlchemy 1.4 sqlalchemy/sqlalchemy#5915 (reply in thread)
CompileError: Unconsumed column namesIssue: SQLAlchemy: Investigate
CompileError: Unconsumed column names#78visit_update#84MutableDictimplementation can be used for implementing CrateDB'sOBJECTtype, see SQLAlchemy: Use JSON type adapter for implementing CrateDB'sOBJECTcrate-python#561 (review).More
visit_update_14method.Reference: Add support for SQLAlchemy 1.4 crate-python#391 (review)
With kind regards,
Andreas.