[5.x]: Disabled variant makes it impossible to change sorting of variants

[white-lukas]

What happened?

Description

When you have a disabled variant, the sort order of variants is not saved for all variants that are under this variant.

Take a product with 3 variants:

• variant 1 -> disabled
• variant 2 -> enabled
• variant 3 -> enabled

When changing the order of variant 2 and 3 this is not saved.
But when first moving variant 1 as the latest variant and saving the product
so you have

• variant 2 -> enabled
• variant 3 -> enabled
• variant 1 -> disabled

After this it is possible to change the sorting of variant 2 and 3.

So it seems that the sorting under a disabled variant isn't getting applied.
When having more variants, everything works above the disabled variant, everything after isn't getting applied.

Craft CMS version

5.9.17

Craft Commerce version

5.6.1

PHP version

8.3

Operating system and version

No response

Database type and version

mysql 8.0

Image driver and version

No response

Installed plugins and versions

No response

[linear]

COM-550

[nfourtythree]

Hi @white-lukas

Thank you for reporting this issue, we have pushed up a fix which will be included in the next release of Commerce.

To get this early, change your craftcms/commerce requirement in your project's composer.json to:

"require": {
  "craftcms/commerce": "5.x-dev as 5.6.1.1",
  "...": "..."
}

Then run composer update.

Thanks!

[lukeholder]

Commerce 5.6.2 is now out with this fix. Thanks!