added bailout message TODOs

Author: firewave

lib/astutils.cpp

@@ -69,7 +69,7 @@ static int findArgumentPosRecursive(const Token* tok, const Token* tokToFind,  b
 {
     ++depth;
     if (!tok || depth >= 100)
-        return -1;
+        return -1; // TODO: add bailout message
     if (tok->str() == ",") {
         int res = findArgumentPosRecursive(tok->astOperand1(), tokToFind, found, depth);
         if (res == -1)
@@ -112,7 +112,7 @@ static void astFlattenCopy(T* tok, const char* op, OuputIterator out, int depth
 {
     --depth;
     if (!tok || depth < 0)
-        return;
+        return; // TODO: add bailout message
     if (strcmp(tok->str().c_str(), op) == 0) {
         astFlattenCopy(tok->astOperand1(), op, out, depth);
         astFlattenCopy(tok->astOperand2(), op, out, depth);
@@ -140,7 +140,7 @@ nonneg int astCount(const Token* tok, const char* op, int depth)
 {
     --depth;
     if (!tok || depth < 0)
-        return 0;
+        return 0; // TODO: add bailout message
     if (strcmp(tok->str().c_str(), op) == 0)
         return astCount(tok->astOperand1(), op, depth) + astCount(tok->astOperand2(), op, depth);
     return 1;
@@ -1129,6 +1129,7 @@ bool exprDependsOnThis(const Token* expr, bool onVar, nonneg int depth)
         return true;
     if (depth >= 1000)
         // Abort recursion to avoid stack overflow
+        // TODO: add bailout message
         return true;
     ++depth;
 
@@ -1273,6 +1274,7 @@ static SmallVector<ReferenceToken> followAllReferencesInternal(const Token* tok,
     if (!tok)
         return {};
     if (depth < 0) {
+        // TODO: add bailout message
         SmallVector<ReferenceToken> refs_result;
         refs_result.emplace_back(tok, std::move(errors));
         return refs_result;
@@ -2931,7 +2933,7 @@ static bool isExpressionChangedAt(const F& getExprTok,
                                   int depth)
 {
     if (depth < 0)
-        return true;
+        return true; // TODO: add bailout message
     if (!tok)
         return false;
     if (!tok->isMutableExpr())
@@ -2990,7 +2992,7 @@ Token* findVariableChanged(Token *start, const Token *end, int indirect, const n
     if (!precedes(start, end))
         return nullptr;
     if (depth < 0)
-        return start;
+        return start; // TODO: add bailout message
     auto getExprTok = utils::memoize([&] {
         return findExpression(start, exprid);
     });
@@ -3089,7 +3091,7 @@ static const Token* findExpressionChangedImpl(const Token* expr,
                                               Find find)
 {
     if (depth < 0)
-        return start;
+        return start; // TODO: add bailout message
     if (!precedes(start, end))
         return nullptr;
     const Token* result = nullptr;

lib/checkstl.cpp

@@ -1078,7 +1078,7 @@ static const ValueFlow::Value* getInnerLifetime(const Token* tok,
                                                 int depth = 4)
 {
     if (depth < 0)
-        return nullptr;
+        return nullptr;// TODO: add bailout message
     if (!tok)
         return nullptr;
     for (const ValueFlow::Value& val : tok->values()) {

lib/forwardanalyzer.cpp

@@ -580,7 +580,7 @@ namespace {
          */
         Progress updateRange(Token* start, const Token* end, int depth = 20) {
             if (depth < 0)
-                return Break(Analyzer::Terminate::Bail);
+                return Break(Analyzer::Terminate::Bail); // TODO: add bailout message
             std::size_t i = 0;
             for (Token* tok = start; precedes(tok, end); tok = tok->next()) {
                 Token* next = nullptr;

lib/programmemory.cpp

@@ -1388,7 +1388,7 @@ namespace {
 
             nonneg int n = astCount(expr, expr->str().c_str());
             if (n > 50)
-                return unknown();
+                return unknown(); // TODO: add bailout message
             std::vector<const Token*> conditions1 = flattenConditions(expr);
             if (conditions1.empty())
                 return unknown();
@@ -1405,7 +1405,7 @@ namespace {
             }
             if (condValues.size() == conditions1.size() && allNegated)
                 return negatedValue;
-            if (n > 4)
+            if (n > 4) // TODO: add bailout message
                 return unknown();
             if (!sortConditions(conditions1))
                 return unknown();
@@ -1646,6 +1646,7 @@ namespace {
                         return execute(tok);
                     });
                     if (f) {
+                        // TODO: add bailout message
                         if (fdepth >= 0 && !f->isImplicitlyVirtual()) {
                             ProgramMemory functionState;
                             for (std::size_t i = 0; i < args.size(); ++i) {
@@ -1734,7 +1735,7 @@ namespace {
                     depth++;
                 }};
             if (depth < 0)
-                return unknown();
+                return unknown(); // TODO: add bailout message
             ValueFlow::Value v = unknown();
             if (updateValue(v, executeImpl(expr)))
                 return v;

lib/valueflow.cpp

@@ -1019,7 +1019,7 @@ static std::vector<MathLib::bigint> minUnsignedValue(const Token* tok, int depth
     if (!tok)
         return result;
     if (depth < 0)
-        return result;
+        return result; // TODO: add bailout message
     if (const ValueFlow::Value* v = tok->getKnownValue(ValueFlow::Value::ValueType::INT)) {
         result = {v->intvalue};
     } else if (!Token::Match(tok, "-|%|&|^") && tok->isConstOp() && tok->astOperand1() && tok->astOperand2()) {
@@ -1523,7 +1523,7 @@ static std::vector<ValueFlow::LifetimeToken> getLifetimeTokens(const Token* tok,
     if (pred(tok))
         return {{tok, std::move(errorPath)}};
     if (depth < 0)
-        return {{tok, std::move(errorPath)}};
+        return {{tok, std::move(errorPath)}}; // TODO: add bailout message
     if (var && var->declarationId() == tok->varId()) {
         if (var->isReference() || var->isRValueReference()) {
             const Token * const varDeclEndToken = var->declEndToken();
@@ -2319,7 +2319,7 @@ struct LifetimeStore {
 static bool hasBorrowingVariables(const std::list<Variable>& vars, const std::vector<const Token*>& args, int depth = 10)
 {
     if (depth < 0)
-        return true;
+        return true; // TODO: add bailout message
     return std::any_of(vars.cbegin(), vars.cend(), [&](const Variable& var) {
         if (const ValueType* vt = var.valueType()) {
             if (vt->pointer > 0 &&
@@ -3614,7 +3614,7 @@ static void valueFlowSymbolic(const TokenList& tokenlist, const SymbolDatabase&
 static const Token* isStrlenOf(const Token* tok, const Token* expr, int depth = 10)
 {
     if (depth < 0)
-        return nullptr;
+        return nullptr; // TODO: add bailout message
     if (!tok)
         return nullptr;
     if (!expr)
@@ -6096,6 +6096,7 @@ static bool isContainerSizeChangedByFunction(const Token* tok,
                 // Argument not used
                 if (!arg->nameToken())
                     return false;
+                // TODO: add bailout message
                 if (depth > 0)
                     return isContainerSizeChanged(arg->nameToken(),
                                                   scope->bodyStart,

lib/vf_analyzers.cpp

@@ -118,7 +118,7 @@ struct ValueFlowAnalyzer : Analyzer {
         if (!tok)
             return {};
         if (depth < 0)
-            return {};
+            return {}; // TODO: add bailout message
         depth--;
         if (analyze(tok, Direction::Forward).isRead()) {
             ConditionState result;
@@ -826,7 +826,7 @@ static bool bifurcateVariableChanged(const Variable* var,
 static bool bifurcate(const Token* tok, const std::set<nonneg int>& varids, const Settings& settings, int depth)
 {
     if (depth < 0)
-        return false;
+        return false; // TODO: add bailout message
     if (!tok)
         return true;
     if (tok->hasKnownIntValue())