We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent c1f6a41 commit 6f63179Copy full SHA for 6f63179
1 file changed
test/testsarif.cpp
@@ -559,7 +559,7 @@ int main() {
559
ASSERT(region.find("startLine") != region.end());
560
ASSERT(region.find("startColumn") != region.end());
561
562
- // Line numbers should be positive, columns can be 0 or positive
+ // Line numbers should be positive, columns should be positive (SARIF requires >= 1)
563
if (region.at("startLine").is<double>())
564
{
565
const int64_t line = static_cast<int64_t>(region.at("startLine").get<double>());
@@ -569,7 +569,7 @@ int main() {
569
if (region.at("startColumn").is<double>())
570
571
const int64_t col = static_cast<int64_t>(region.at("startColumn").get<double>());
572
- ASSERT(col >= 0);
+ ASSERT(col > 0);
573
}
574
575
0 commit comments