ErrorLogger: do not allocate huge std::string when column is -1

danmar · danmar · commit 68bb724dcc87 · 2022-07-07T15:07:17.000+02:00
diff --git a/lib/errorlogger.cpp b/lib/errorlogger.cpp
@@ -489,7 +489,7 @@ static std::string readCode(const std::string &file, int linenr, int column, con
     std::string::size_type pos = 0;
     while ((pos = line.find('\t', pos)) != std::string::npos)
         line[pos] = ' ';
-    return line + endl + std::string((column>0 ? column-1 : column), ' ') + '^';
+    return line + endl + std::string((column>0 ? column-1 : 0), ' ') + '^';
 }
 
 static void replaceColors(std::string& source)

Original file line number	Diff line number	Diff line change
`@@ -489,7 +489,7 @@ static std::string readCode(const std::string &file, int linenr, int column, con`
`489`	`489`	`std::string::size_type pos = 0;`
`490`	`490`	`while ((pos = line.find('\t', pos)) != std::string::npos)`
`491`	`491`	`line[pos] = ' ';`
`492`		`- return line + endl + std::string((column>0 ? column-1 : column), ' ') + '^';`
	`492`	`+ return line + endl + std::string((column>0 ? column-1 : 0), ' ') + '^';`
`493`	`493`	`}`
`494`	`494`
`495`	`495`	`static void replaceColors(std::string& source)`