feat: remove old settlement forwarder#4429
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the CowSettlementForwarder contract, its ABI, and all associated configuration fields and methods across the driver and end-to-end test suites. Review feedback highlights that these changes may cause compilation errors in the eip7702 module and leave parallel settlement tests in a broken state, necessitating updates to the test logic and dependencies.
igorroncevic
force-pushed
the
feat/remove_old_forwarder_contract
branch
from
4dc8037 to
e94152c
Compare
igorroncevic
force-pushed
the
feat/remove_old_forwarder_contract
branch
from
5b07f38 to
cb275c3
Compare
| // The old implementation still lives in eip7702.rs for the stacked delegate PR, | ||
| // but it depends on the removed forwarder binding. This minimal stub allows the | ||
| // CI to pass. | ||
| pub mod eip7702 { | ||
| use {super::Solver, crate::infra::blockchain::Ethereum, tracing::instrument}; | ||
|
|
||
| #[instrument(name = "setup_eip7702", skip_all)] | ||
| pub async fn setup(_solvers: &[Solver], _eth: &Ethereum) -> anyhow::Result<()> { | ||
| Ok(()) | ||
| } | ||
| } |
There was a problem hiding this comment.
Minimal stub added here so any issues with eip7702.rs wouldn't interrupt the CI. It will be removed by the subsequent PR.
| mod order_cancellation; | ||
| mod order_simulation; | ||
| mod parallel_settlement; | ||
| // mod parallel_settlement; |
There was a problem hiding this comment.
Commented out EIP-7702 related tests until the subsequent PR gets merged.
AryanGodara
left a comment
AryanGodara
left a comment
There was a problem hiding this comment.
lgtm 👌🏼
I also tried to confirm if this'll break config in the infra repo
But no prod or staging driver currently sets forwarder-contract, so we're safe to merge
2 participants
Description
This PR removes the old
CowSettlementForwarderimplementation and its config surface.The forwarder is being replaced by
Solver7702Delegatein the follow-up PR. Removing the old contract, artifact, bindings, and explicitforwarder-contractconfig first keeps the stack easier to review: this PR is only the cleanup of the old path, while #4430 introduces the new delegate behavior.Changes
CowSettlementForwarder.soland its artifact.cowsettlementforwarderbindings and facade wiring.forwarder_contract/forwarder-contractfrom driver config loading and solver config.Solver7702Delegateimplementation for the follow-up PR.How to test
This PR is intended to be validated together with #4430, which adds the replacement implementation.
just generate-contractsjust fmt --checkjust clippyjust test-unit