return to public fields to make pydantic happy

Author: lukaskratzel

src/corbado_python_sdk/corbado_sdk.py

@@ -70,8 +70,8 @@ def sessions(self) -> SessionService:
         """
         if not self._sessions:
             self._sessions = SessionService(
-                _issuer=self.config.issuer,
-                _jwks_uri=self.config.frontend_api + "/.well-known/jwks",
+                issuer=self.config.issuer,
+                jwks_uri=self.config.frontend_api + "/.well-known/jwks",
                 project_id=self.config.project_id,
             )
 

src/corbado_python_sdk/services/implementation/session_service.py

@@ -25,20 +25,20 @@ class SessionService(BaseModel):
 
     Attributes:
         model_config (ConfigDict): Configuration dictionary for the model.
+        issuer (str): Issuer of the session tokens.
+        jwks_uri (str): URI of the JSON Web Key Set (JWKS) endpoint.
         last_session_token_validation_result (str): Result of the last short session validation.
-        project_id (str): Corbado Project Id.
-        _issuer (str): Issuer of the session tokens.
-        _jwks_uri (str): URI of the JSON Web Key Set (JWKS) endpoint.
         _jwk_client (PyJWKClient): JSON Web Key (JWK) client for handling JWKS.
+        project_id (str): Corbado Project Id.
     """
 
     model_config = ConfigDict(arbitrary_types_allowed=True, validate_assignment=True)
 
     # Fields
+    issuer: Annotated[str, StringConstraints(strip_whitespace=True, min_length=1)]
+    jwks_uri: Annotated[str, StringConstraints(strip_whitespace=True, min_length=1)]
     last_session_token_validation_result: str = ""
     project_id: str
-    _issuer: Annotated[str, StringConstraints(strip_whitespace=True, min_length=1)]
-    _jwks_uri: Annotated[str, StringConstraints(strip_whitespace=True, min_length=1)]
     _jwk_client: PyJWKClient
 
     # Constructor
@@ -49,14 +49,16 @@ def __init__(self, **kwargs) -> None:  # type: ignore
         Args:
             **kwargs: Additional keyword arguments to initialize the SessionService.
                 These keyword arguments should include values for the attributes defined in the class,
-                such as 'issuer', '_jwks_uri' and 'last_session_token_validation_result',
+                such as 'issuer', 'jwks_uri', 'last_session_token_validation_result',
+                'cache_keys',cache_jwk_set and 'session_token_cookie_length'.
 
         Raises:
             Any errors raised during the initialization process.
+
         """
         super().__init__(**kwargs)
         self._jwk_client = PyJWKClient(
-            uri=self._jwks_uri,
+            uri=self.jwks_uri,
             lifespan=DEFAULT_SESSION_TOKEN_LENGTH,
         )
 
@@ -140,7 +142,7 @@ def _set_issuer_mismatch_error(self, token_issuer: str) -> None:
         Args:
             token_issuer (str): Token issuer.
         """
-        self.last_session_token_validation_result = f"Mismatch in issuer (configured: {self._issuer}, JWT: {token_issuer})"
+        self.last_session_token_validation_result = f"Mismatch in issuer (configured: {self.issuer}, JWT: {token_issuer})"
 
     def _set_validation_error(self, error: Exception) -> None:
         """Set validation error.
@@ -164,8 +166,7 @@ def _validate_issuer(self, token_issuer: str, session_token: str) -> None:
         """
         if not token_issuer:
             raise TokenValidationException(
-                error_type=ValidationErrorType.CODE_JWT_ISSUER_EMPTY,
-                message=f"Issuer is empty. Session token: {session_token}"
+                error_type=ValidationErrorType.CODE_JWT_ISSUER_EMPTY, message=f"Issuer is empty. Session token: {session_token}"
             )
 
         # Check for old Frontend API (without .cloud.)
@@ -179,8 +180,8 @@ def _validate_issuer(self, token_issuer: str, session_token: str) -> None:
             return
 
         # Check against the configured issuer (e.g., a custom domain or CNAME)
-        if token_issuer != self._issuer:
+        if token_issuer != self.issuer:
             raise TokenValidationException(
                 error_type=ValidationErrorType.CODE_JWT_ISSUER_MISSMATCH,
-                message=f"Issuer mismatch (configured via FrontendAPI: '{self._issuer}', JWT issuer: '{token_issuer}')",
+                message=f"Issuer mismatch (configured via FrontendAPI: '{self.issuer}', JWT issuer: '{token_issuer}')",
             )

tests/unit/test_session_service.py

@@ -276,4 +276,4 @@ def test_set_cname_expect_issuer_changed(self):
 
         sdk = CorbadoSDK(config=config)
         sessions: SessionService = sdk.sessions
-        self.assertEqual("https://" + test_cname, sessions._issuer)
+        self.assertEqual("https://" + test_cname, sessions.issuer)