refactor: move versionInfo check to cmd

Author: muthukrishnan24

cmd/cmd.go

@@ -3,16 +3,14 @@ package cmd
 
 import (
 	"fmt"
+	"runtime/debug"
 
 	"github.com/urfave/cli/v2"
 )
 
-var versionTmpl = `commitlint version %s - built from %s on %s
-`
-
 // New returns commitlint cli.App
 func New(versionNo, commitHash, builtTime string) *cli.App {
-	versionInfo := fmt.Sprintf(versionTmpl, versionNo, commitHash, builtTime)
+	versionInfo := formVersionInfo(versionNo, commitHash, builtTime)
 
 	cmds := []*cli.Command{
 		createCmd(),
@@ -121,3 +119,32 @@ func verifyCmd() *cli.Command {
 		Action: verifyCallback,
 	}
 }
+
+func formVersionInfo(versionInfo, commitInfo, buildTime string) string {
+	versionTmpl := `commitlint version %s - built from %s on %s
+`
+	versionInfo, commitInfo, buildTime = getVersionInfo(versionInfo, commitInfo, buildTime)
+	return fmt.Sprintf(versionTmpl, versionInfo, commitInfo, buildTime)
+}
+
+func getVersionInfo(version, commit, build string) (versionInfo, commitInfo, buildTime string) {
+	if build != "" {
+		return version, commit, build
+	}
+
+	info, ok := debug.ReadBuildInfo()
+	if !ok {
+		return "master", "unknown", "unknown"
+	}
+
+	checkSum := "unknown"
+	if info.Main.Sum != "" {
+		checkSum = info.Main.Sum
+	}
+
+	versionInfo = info.Main.Version
+	commitInfo = "(" + "checksum: " + checkSum + ")"
+	buildTime = "unknown"
+
+	return versionInfo, commitInfo, buildTime
+}

main.go

@@ -3,7 +3,6 @@ package main
 import (
 	"fmt"
 	"os"
-	"runtime/debug"
 
 	"github.com/conventionalcommit/commitlint/cmd"
 )
@@ -16,36 +15,11 @@ var (
 	BuildTime string
 )
 
-func init() {
-	setVersionInfo()
-}
-
 func main() {
 	app := cmd.New(Version, Commit, BuildTime)
 	err := app.Run(os.Args)
 	if err != nil {
-		fmt.Println("Error: ", err)
+		fmt.Println("Error:", err)
 		os.Exit(cmd.ErrExitCode)
 	}
 }
-
-func setVersionInfo() {
-	if BuildTime == "" {
-		info, ok := debug.ReadBuildInfo()
-		if ok {
-			checkSum := "unknown"
-			if info.Main.Sum != "" {
-				checkSum = info.Main.Sum
-			}
-
-			Version = info.Main.Version
-			Commit = "(" + "checksum: " + checkSum + ")"
-			BuildTime = "unknown"
-			return
-		}
-
-		Version = "master"
-		Commit = "unknown"
-		BuildTime = "unknown"
-	}
-}