-
-
Notifications
You must be signed in to change notification settings - Fork 112
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
The README workflow example uses on: issue_comment with an if condition that checks only for the CLA magic phrase.
issue_comment events are fired for both pull requests and normal issues, so posting the phrase on a normal issue can run the CLA action without PR context.
To Reproduce
- Configure the workflow as shown in the README (
issue_comment+ currentifcondition). - Open a normal GitHub Issue (not a PR).
- Add this comment to the issue:
I have read the CLA Document and I hereby sign the CLA. - Observe that the workflow is triggered for that issue comment.
Expected behavior
The CLA workflow should only run for:
pull_request_targetevents, orissue_commentevents where the comment is on a pull request (github.event.issue.pull_requestexists).
Non-PR issue comments should not trigger CLA processing.
Screenshots
N/A
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working