refactor: align plugins list with gateway API

- Use case-insensitive PluginMode enum for --mode
- Assume /admin/plugins response shape ({"plugins": [...]})
- Update tests to use invoke_typer_command for accurate option defaults/coverage

Signed-off-by: Matthew Grigsby <38010437+MatthewGrigsby@users.noreply.github.com>

Author: MatthewGrigsby

cforge/commands/resources/plugins.py

@@ -16,6 +16,7 @@
 """
 
 # Standard
+from enum import Enum
 from typing import Any, Dict, Optional
 
 # Third-Party
@@ -33,6 +34,28 @@
 )
 
 
+class _CaseInsensitiveEnum(str, Enum):
+    """Enum that supports case-insensitive parsing for CLI options."""
+
+    @classmethod
+    def _missing_(cls, value: object) -> Optional["_CaseInsensitiveEnum"]:
+        if not isinstance(value, str):
+            return None
+        value_folded = value.casefold()
+        for member in cls:
+            if member.value.casefold() == value_folded:
+                return member
+        return None
+
+
+class PluginMode(_CaseInsensitiveEnum):
+    """Valid plugin mode filters supported by the gateway admin API."""
+
+    ENFORCE = "enforce"
+    PERMISSIVE = "permissive"
+    DISABLED = "disabled"
+
+
 def _handle_plugins_exception(exception: Exception) -> None:
     """Provide plugin-specific hints and raise a CLI error."""
     console = get_console()
@@ -47,7 +70,7 @@ def _handle_plugins_exception(exception: Exception) -> None:
 
 def plugins_list(
     search: Optional[str] = typer.Option(None, "--search", help="Search by plugin name, description, or author"),
-    mode: Optional[str] = typer.Option(None, "--mode", help="Filter by mode (enforce, permissive, disabled)"),
+    mode: Optional[PluginMode] = typer.Option(None, "--mode", help="Filter by mode"),
     hook: Optional[str] = typer.Option(None, "--hook", help="Filter by hook type"),
     tag: Optional[str] = typer.Option(None, "--tag", help="Filter by plugin tag"),
     json_output: bool = typer.Option(False, "--json", help="Output as JSON"),
@@ -60,7 +83,7 @@ def plugins_list(
         if search:
             params["search"] = search
         if mode:
-            params["mode"] = mode
+            params["mode"] = mode.value
         if hook:
             params["hook"] = hook
         if tag:
@@ -71,18 +94,7 @@ def plugins_list(
         if json_output:
             print_json(result, "Plugins")
         else:
-            plugins: list[dict[str, Any]] = []
-            if isinstance(result, dict):
-                if "plugins" in result:
-                    raw_plugins = result.get("plugins", [])
-                    if isinstance(raw_plugins, list):
-                        plugins = raw_plugins
-                    elif isinstance(raw_plugins, dict):
-                        plugins = [raw_plugins]
-                else:
-                    plugins = [result]
-            elif isinstance(result, list):
-                plugins = result
+            plugins: list[dict[str, Any]] = result["plugins"]
 
             if plugins:
                 print_table(plugins, "Plugins", ["name", "version", "author", "mode", "status", "priority", "hooks", "tags"])

tests/commands/resources/test_plugins.py

@@ -12,14 +12,26 @@
 import typer
 
 # First-Party
-from cforge.commands.resources.plugins import plugins_get, plugins_list, plugins_stats
+from cforge.commands.resources.plugins import PluginMode, plugins_get, plugins_list, plugins_stats
 from cforge.common import AuthenticationError, CLIError
-from tests.conftest import patch_functions
+from tests.conftest import invoke_typer_command, patch_functions
 
 
 class TestPluginCommands:
     """Tests for plugins commands."""
 
+    def test_plugin_mode_enum_is_case_insensitive(self) -> None:
+        """Typer Enum choices should accept case-insensitive values."""
+        assert PluginMode("EnFoRcE") == PluginMode.ENFORCE
+
+    def test_plugin_mode_enum_missing_non_string(self) -> None:
+        """Non-string values should not be coerced into Enum members."""
+        assert PluginMode._missing_(123) is None
+
+    def test_plugin_mode_enum_missing_unknown_value(self) -> None:
+        """Unknown strings should not be coerced into Enum members."""
+        assert PluginMode._missing_("nope") is None
+
     def test_plugins_list_success(self, mock_console) -> None:
         """Test plugins list command with table output."""
         mock_response = {
@@ -37,7 +49,7 @@ def test_plugins_list_success(self, mock_console) -> None:
             make_authenticated_request={"return_value": mock_response},
             print_table=None,
         ) as mocks:
-            plugins_list(json_output=False)
+            invoke_typer_command(plugins_list)
             mocks.print_table.assert_called_once()
 
     def test_plugins_list_json_output(self, mock_console) -> None:
@@ -49,14 +61,14 @@ def test_plugins_list_json_output(self, mock_console) -> None:
             make_authenticated_request={"return_value": mock_response},
             print_json=None,
         ) as mocks:
-            plugins_list(json_output=True)
+            invoke_typer_command(plugins_list, json_output=True)
             mocks.print_json.assert_called_once()
 
     def test_plugins_list_no_results(self, mock_console) -> None:
         """Test plugins list with no results."""
         mock_response = {"plugins": [], "total": 0, "enabled_count": 0, "disabled_count": 0}
         with patch_functions("cforge.commands.resources.plugins", get_console=mock_console, make_authenticated_request={"return_value": mock_response}):
-            plugins_list(json_output=False)
+            invoke_typer_command(plugins_list)
 
         assert any("No plugins found" in str(call) for call in mock_console.print.call_args_list)
 
@@ -68,7 +80,7 @@ def test_plugins_list_with_filters(self, mock_console) -> None:
             make_authenticated_request={"return_value": {"plugins": [], "total": 0, "enabled_count": 0, "disabled_count": 0}},
             print_table=None,
         ) as mocks:
-            plugins_list(search="pii", mode="enforce", hook="tool_pre_invoke", tag="security", json_output=False)
+            invoke_typer_command(plugins_list, search="pii", mode=PluginMode.ENFORCE, hook="tool_pre_invoke", tag="security")
 
             call_args = mocks.make_authenticated_request.call_args
             assert call_args[0][0] == "GET"
@@ -79,7 +91,7 @@ def test_plugins_list_error(self, mock_console) -> None:
         """Test plugins list error handling."""
         with patch_functions("cforge.commands.resources.plugins", get_console=mock_console, make_authenticated_request={"side_effect": Exception("API error")}):
             with pytest.raises(typer.Exit):
-                plugins_list(json_output=False)
+                invoke_typer_command(plugins_list)
 
     def test_plugins_get_success(self, mock_console) -> None:
         """Test plugins get command."""
@@ -90,14 +102,14 @@ def test_plugins_get_success(self, mock_console) -> None:
             make_authenticated_request={"return_value": mock_plugin},
             print_json=None,
         ) as mocks:
-            plugins_get(name="pii_filter")
+            invoke_typer_command(plugins_get, name="pii_filter")
             mocks.print_json.assert_called_once()
 
     def test_plugins_get_error(self, mock_console) -> None:
         """Test plugins get error handling."""
         with patch_functions("cforge.commands.resources.plugins", get_console=mock_console, make_authenticated_request={"side_effect": Exception("API error")}):
             with pytest.raises(typer.Exit):
-                plugins_get(name="pii_filter")
+                invoke_typer_command(plugins_get, name="pii_filter")
 
     def test_plugins_stats_success(self, mock_console) -> None:
         """Test plugins stats command."""
@@ -108,14 +120,14 @@ def test_plugins_stats_success(self, mock_console) -> None:
             make_authenticated_request={"return_value": mock_stats},
             print_json=None,
         ) as mocks:
-            plugins_stats()
+            invoke_typer_command(plugins_stats)
             mocks.print_json.assert_called_once()
 
     def test_plugins_stats_error(self, mock_console) -> None:
         """Test plugins stats error handling."""
         with patch_functions("cforge.commands.resources.plugins", get_console=mock_console, make_authenticated_request={"side_effect": Exception("API error")}):
             with pytest.raises(typer.Exit):
-                plugins_stats()
+                invoke_typer_command(plugins_stats)
 
     def test_plugins_list_forbidden_shows_permission_hint(self, mock_console) -> None:
         """Test plugins list shows a targeted hint on forbidden/admin failures."""
@@ -125,7 +137,7 @@ def test_plugins_list_forbidden_shows_permission_hint(self, mock_console) -> Non
             make_authenticated_request={"side_effect": AuthenticationError("Authentication required but not configured")},
         ):
             with pytest.raises(typer.Exit):
-                plugins_list(json_output=False)
+                invoke_typer_command(plugins_list)
 
         assert any("Requires admin.plugins permission" in str(call) for call in mock_console.print.call_args_list)
 
@@ -137,6 +149,6 @@ def test_plugins_list_not_found_shows_admin_api_hint(self, mock_console) -> None
             make_authenticated_request={"side_effect": CLIError("API request failed (404): Not Found")},
         ):
             with pytest.raises(typer.Exit):
-                plugins_list(json_output=False)
+                invoke_typer_command(plugins_list)
 
         assert any("Admin plugin API unavailable" in str(call) for call in mock_console.print.call_args_list)