🪴 #67 error handling infinite loop issue

Author: ishaileshmishra

src/main/java/com/contentstack/sdk/Query.java

@@ -1216,8 +1216,8 @@ private void includeLivePreview() {
         Config ci = contentTypeInstance.stackInstance.config;
         if (ci.enableLivePreview
                 && ci.livePreviewContentType.equalsIgnoreCase(contentTypeUid)
-                && ci.livePreviewHash == null
-                || ci.livePreviewHash.isEmpty()) {
+                && (ci.livePreviewHash == null
+                || ci.livePreviewHash.isEmpty())) {
             ci.livePreviewHash = "init";
         }
     }

src/test/java/com/contentstack/sdk/TestStack.java

@@ -115,12 +115,6 @@ void testGetDeliveryToken() {
         assertTrue(stack.getDeliveryToken().startsWith("blt"));
     }
 
-    @Test
-    @Deprecated
-    @Order(14)
-    void testGetAccessToken() {
-        assertTrue(stack.getAccessToken().startsWith("blt"));
-    }
 
     @Test
     @Order(15)
@@ -236,7 +230,7 @@ void testSyncLocaleWithoutCallback() {
     @Order(28)
     void testSyncPublishTypeEntryPublished() {
         // deepcode ignore NullPassTo/test: <please specify a reason of ignoring this>
-        stack.syncPublishType(Stack.PublishType.entry_published, null);
+        stack.syncPublishType(Stack.PublishType.ENTRY_PUBLISHED, null);
         assertEquals(3, stack.syncParams.length());
         assertEquals("entry_published", stack.syncParams.get("type"));
         assertTrue(stack.syncParams.has("init"));
@@ -246,7 +240,7 @@ void testSyncPublishTypeEntryPublished() {
     @Test
     @Order(29)
     void testSyncPublishTypeAssetDeleted() {
-        stack.syncPublishType(Stack.PublishType.asset_deleted, null);
+        stack.syncPublishType(Stack.PublishType.ASSET_DELETED, null);
         assertEquals(3, stack.syncParams.length());
         assertEquals("asset_deleted", stack.syncParams.get("type"));
         assertTrue(stack.syncParams.has("init"));
@@ -256,7 +250,7 @@ void testSyncPublishTypeAssetDeleted() {
     @Test
     @Order(30)
     void testSyncPublishTypeAssetPublished() {
-        stack.syncPublishType(Stack.PublishType.asset_published, null);
+        stack.syncPublishType(Stack.PublishType.ASSET_PUBLISHED, null);
         assertEquals(3, stack.syncParams.length());
         assertEquals("asset_published", stack.syncParams.get("type"));
         assertTrue(stack.syncParams.has("init"));
@@ -266,7 +260,7 @@ void testSyncPublishTypeAssetPublished() {
     @Test
     @Order(31)
     void testSyncPublishTypeAssetUnPublished() {
-        stack.syncPublishType(Stack.PublishType.asset_unpublished, null);
+        stack.syncPublishType(Stack.PublishType.ASSET_UNPUBLISHED, null);
         assertEquals(3, stack.syncParams.length());
         assertEquals("asset_unpublished", stack.syncParams.get("type"));
         assertTrue(stack.syncParams.has("init"));
@@ -276,7 +270,7 @@ void testSyncPublishTypeAssetUnPublished() {
     @Test
     @Order(32)
     void testSyncPublishTypeContentTypeDeleted() {
-        stack.syncPublishType(Stack.PublishType.content_type_deleted, null);
+        stack.syncPublishType(Stack.PublishType.CONTENT_TYPE_DELETED, null);
         assertEquals(3, stack.syncParams.length());
         assertEquals("content_type_deleted", stack.syncParams.get("type"));
         assertTrue(stack.syncParams.has("init"));
@@ -286,7 +280,7 @@ void testSyncPublishTypeContentTypeDeleted() {
     @Test
     @Order(33)
     void testSyncPublishTypeEntryDeleted() {
-        stack.syncPublishType(Stack.PublishType.entry_deleted, null);
+        stack.syncPublishType(Stack.PublishType.ENTRY_DELETED, null);
         assertEquals(3, stack.syncParams.length());
         assertEquals("entry_deleted", stack.syncParams.get("type"));
         assertTrue(stack.syncParams.has("init"));
@@ -297,7 +291,7 @@ void testSyncPublishTypeEntryDeleted() {
     @Order(34)
     void testSyncPublishTypeEntryUnpublished() {
         // deepcode ignore NullPassTo/test: <please specify a reason of ignoring this>
-        stack.syncPublishType(Stack.PublishType.entry_unpublished, null);
+        stack.syncPublishType(Stack.PublishType.ENTRY_UNPUBLISHED, null);
         assertEquals(3, stack.syncParams.length());
         assertEquals("entry_unpublished", stack.syncParams.get("type"));
         assertTrue(stack.syncParams.has("init"));
@@ -309,11 +303,11 @@ void testSyncPublishTypeEntryUnpublished() {
     void testSyncIncludingMultipleParams() {
         Date newDate = new Date();
         String startFrom = stack.convertUTCToISO(newDate);
-        stack.sync("product", newDate, "en-us", Stack.PublishType.entry_published, null);
+        stack.sync("product", newDate, "en-us", Stack.PublishType.ENTRY_PUBLISHED, null);
         assertEquals(6, stack.syncParams.length());
-        assertEquals("entry_published", stack.syncParams.get("type"));
+        assertEquals("entry_published", stack.syncParams.get("type").toString().toLowerCase());
         assertEquals("en-us", stack.syncParams.get("locale"));
-        assertEquals("product", stack.syncParams.get("content_type_uid"));
+        assertEquals("product", stack.syncParams.get("content_type_uid").toString().toLowerCase());
         assertEquals(startFrom, stack.syncParams.get("start_from"));
         assertTrue(stack.syncParams.has("init"));
         assertTrue(stack.syncParams.has("environment"));
@@ -371,7 +365,7 @@ void testConfigGetHost() {
     }
 
     @Test
-    @Disabled
+    @Disabled("No relevant code")
     @Order(41)
     void testSynchronizationAPIRequest() throws IllegalAccessException {
         Dotenv dotenv = Dotenv.load();
@@ -396,7 +390,7 @@ public void onCompletion(SyncStack response, Error error) {
     }
 
     @Test
-    @Disabled
+    @Disabled("No relevant code")
     @Order(42)
     void testSyncPaginationToken() throws IllegalAccessException {
         Dotenv dotenv = Dotenv.load();