Skip to content

Commit e021fe2

Browse files
committed
Fixed PR comments
1 parent e0293d3 commit e021fe2

File tree

5 files changed

+30
-11
lines changed

5 files changed

+30
-11
lines changed

packages/contentstack-audit/src/audit-base-command.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,9 @@ export abstract class AuditBaseCommand extends BaseCommand<typeof AuditBaseComma
118118
!isEmpty(missingCtRefsInWorkflow) ||
119119
!isEmpty(missingCtRefsInExtensions) ||
120120
!isEmpty(missingSelectFeild) ||
121-
!isEmpty(missingRefInCustomRoles)
121+
!isEmpty(missingRefInCustomRoles) ||
122+
!isEmpty(missingEnvLocalesInAssets) ||
123+
!isEmpty(missingEnvLocalesInEntries)
122124
);
123125
}
124126

@@ -188,7 +190,7 @@ export abstract class AuditBaseCommand extends BaseCommand<typeof AuditBaseComma
188190

189191
await this.prepareReport('Entries_Title_feild', missingTitleFields);
190192

191-
await this.prepareReport('Entry_Missing_Locale_and_Env', missingEnvLocalesInEntries);
193+
await this.prepareReport('Entry_Missing_Locale_and_Env_in_Publish_Details', missingEnvLocalesInEntries);
192194

193195
break;
194196
case 'workflows':

packages/contentstack-audit/src/config/index.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,15 +89,20 @@ const config = {
8989
'locale',
9090
'environment',
9191
'ctUid',
92-
'ctLocale'
92+
'ctLocale',
93+
'entry_uid',
94+
'publish_locale',
95+
'publish_environment',
96+
'asset_uid'
9397
],
9498
ReportTitleForEntries: {
9599
Entries_Select_feild: 'Entries_Select_feild',
96100
Entries_Mandatory_feild: 'Entries_Mandatory_feild',
97101
Entries_Title_feild: 'Entries_Title_feild',
98-
Entry_Missing_Locale_and_Env: 'Entry_Missing_Locale_and_Env'
102+
Entry_Missing_Locale_and_Env: 'Entry_Missing_Locale_and_Env',
103+
Entry_Missing_Locale_and_Env_in_Publish_Details: 'Entry_Missing_Locale_and_Env_in_Publish_Details'
99104
},
100-
feild_level_modules: ['Entries_Title_feild', 'Entries_Mandatory_feild', 'Entries_Select_feild', 'Entry_Missing_Locale_and_Env'],
105+
feild_level_modules: ['Entries_Title_feild', 'Entries_Mandatory_feild', 'Entries_Select_feild', 'Entry_Missing_Locale_and_Env_in_Publish_Details'],
101106
};
102107

103108
export default config;

packages/contentstack-audit/src/modules/assets.ts

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,10 @@ export default class Assets {
7474
}
7575

7676
for (let propName in this.missingEnvLocales) {
77-
if (!this.missingEnvLocales[propName].length) {
78-
delete this.missingEnvLocales[propName];
77+
if (Array.isArray(this.missingEnvLocales[propName])) {
78+
if (!this.missingEnvLocales[propName].length) {
79+
delete this.missingEnvLocales[propName];
80+
}
7981
}
8082
}
8183

@@ -150,9 +152,15 @@ export default class Assets {
150152
{ color: 'yellow' },
151153
);
152154
if (!Object.keys(this.missingEnvLocales).includes(assetUid)) {
153-
this.missingEnvLocales[assetUid] = [{ uid: assetUid, locale: pd.locale, environment: pd.environment }];
155+
this.missingEnvLocales[assetUid] = [
156+
{ asset_uid: assetUid, publish_locale: pd.locale, publish_environment: pd.environment },
157+
];
154158
} else {
155-
this.missingEnvLocales[assetUid].push({ uid: assetUid, locale: pd.locale, environment: pd.environment });
159+
this.missingEnvLocales[assetUid].push({
160+
asset_uid: assetUid,
161+
publish_locale: pd.locale,
162+
publish_environment: pd.environment,
163+
});
156164
}
157165
this.log($t(auditMsg.SCAN_ASSET_SUCCESS_MSG, { uid: assetUid }), { color: 'green' });
158166
return false;

packages/contentstack-audit/src/modules/entries.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,10 +194,10 @@ export default class Entries {
194194
{ color: 'red' },
195195
);
196196
if (!Object.keys(this.missingEnvLocale).includes(entryUid)) {
197-
this.missingEnvLocale[entryUid] = [{ uid: entryUid, locale: pd.locale, environment: pd.environment, ctUid: ctSchema.uid, ctLocale: code }];
197+
this.missingEnvLocale[entryUid] = [{ entry_uid: entryUid, publish_locale: pd.locale, publish_environment: pd.environment, ctUid: ctSchema.uid, ctLocale: code }];
198198
} else {
199199
this.missingEnvLocale[entryUid].push(
200-
{ uid: entryUid, locale: pd.locale, environment: pd.environment, ctUid: ctSchema.uid, ctLocale: code },
200+
{ entry_uid: entryUid, publish_locale: pd.locale, publish_environment: pd.environment, ctUid: ctSchema.uid, ctLocale: code },
201201
);
202202
}
203203
return false;

packages/contentstack-audit/src/types/content-types.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,10 @@ enum OutputColumn {
155155
'environment' = 'environment',
156156
'ctUid' = 'ctUid',
157157
'ctLocale' = 'ctLocale',
158+
'entry_uid' = 'entry_uid',
159+
'publish_locale' = 'publish_locale',
160+
'publish_environment' = 'publish_environment',
161+
'asset_uid' = 'asset_uid'
158162
}
159163

160164
export {

0 commit comments

Comments
 (0)