refactor(directlogin): remove dead Lift dlServe block + vestigial RestHelper

The bare `POST /my/logins/direct` route has been served by
`code.api.DirectLoginRoutes` (wired into `Http4sApp.baseServices`) since
`LiftRules.statelessDispatch.append(DirectLogin)` was removed from
`Boot.scala`. That left the `dlServe` self-registration block inside
`DirectLogin` as dead code — `super.serve(...)` only does anything when
the object is registered with `LiftRules`, which it no longer is.

Removed:
- the `dlServe` helper (its only job was wrapping a handler in
  `RestHelper.serve`),
- the `dlServe { case Req("my" :: "logins" :: "direct" :: Nil, _, PostRequest) }`
  registration block,
- `extends RestHelper` (now only `MdcLoggable`) — nothing outside the dead
  block used a RestHelper member; there were no `.extract`/`Formats` call
  sites, so no local `Formats` replacement was needed (unlike the
  OAuth2/GatewayLogin/DAuth de-RestHelper cleanups),
- the now-unused `RestHelper` and `NewStyle.HttpCode` imports.

Kept (still have live callers): `createTokenCommonPart`, `getAllParameters`,
`validator`, `validatorFuture`, `validatorFutureWithParams`,
`getUserFromDirectLoginHeaderFuture`, `getUser`, `getConsumer`,
`grantEntitlementsToUseDynamicEndpointsInSpacesInDirectLogin`, and the
token/consumer/user lookup helpers used by the auth flows.

No behavioural change: the removed block was never reachable after the
Boot dispatch removal. obp-api compiles; no test referenced the removed
members.

Author: constantine2nd

obp-api/src/main/scala/code/api/directlogin.scala

@@ -30,7 +30,6 @@ import java.util.Date
 
 import code.api.util.APIUtil._
 import code.api.util.ErrorMessages.{InvalidDirectLoginParameters, attemptedToOpenAnEmptyBox}
-import code.api.util.NewStyle.HttpCode
 import code.api.util._
 import code.consumer.Consumers._
 import code.model.dataAccess.AuthUser
@@ -44,7 +43,6 @@ import com.openbankproject.commons.ExecutionContext.Implicits.global
 import com.openbankproject.commons.model.User
 import net.liftweb.common._
 import net.liftweb.http._
-import net.liftweb.http.rest.RestHelper
 import net.liftweb.mapper.{By, By_>, Descending, OrderBy}
 import net.liftweb.util.Helpers
 import net.liftweb.util.Helpers.tryo
@@ -79,39 +77,8 @@ object JSONFactory {
   }
 }
 
-object DirectLogin extends RestHelper with MdcLoggable {
+object DirectLogin extends MdcLoggable {
 
-  // Our version of serve
-  def dlServe(handler : PartialFunction[Req, JsonResponse]) : Unit = {
-    val obpHandler : PartialFunction[Req, () => Box[LiftResponse]] = {
-      new PartialFunction[Req, () => Box[LiftResponse]] {
-        def apply(r : Req) = {
-          handler(r)
-        }
-        def isDefinedAt(r : Req) = handler.isDefinedAt(r)
-      }
-    }
-    super.serve(obpHandler)
-  }
-
-  dlServe
-  {
-    //Handling get request for a token
-    case Req("my" :: "logins" :: "direct" :: Nil,_ , PostRequest) => {
-      for{
-        (httpCode: Int, message: String, userId:Long) <- createTokenFuture(getAllParameters)
-        _ <- Future{grantEntitlementsToUseDynamicEndpointsInSpacesInDirectLogin(userId)}
-      }   yield {
-        if (httpCode == 200) {
-          (JSONFactory.createTokenJSON(message), HttpCode.`201`(CallContext()))
-        } else {
-          unboxFullOrFail(Empty, None, message, httpCode)
-        }
-      }
-    }
-  }
-
-  
   def grantEntitlementsToUseDynamicEndpointsInSpacesInDirectLogin(userId:Long) = {
     try {
       val resourceUser = UserX.findByResourceUserId(userId).openOrThrowException(s"$InvalidDirectLoginParameters can not find the resourceUser!")