Shouldn't we do a case-insensitive check for commit type?

[rsh-raj]

This tool classify one of your commit 5f9c312 as False. This is due to Capitalization of first word in "Refactor". I think we should do case-insensitive check for commit type.

[thekaveman]

Thanks for the question @rsh-raj. The commit you mention 5f9c312 is a merge commit made on GitHub, so the tool never ran on this commit.

We are happy to review a PR with tests if you see a bug that should be fixed!

[jonathanraesch]

The specification states that

15. The units of information that make up Conventional Commits MUST NOT be treated as case sensitive by implementors, with the exception of BREAKING CHANGE which MUST be uppercase.

But this tool only allows lowercase commit types. This is clearly a bug.

[jonathanraesch]

#135 should fix this. I could not find any case-sensitive units other than types and scopes.

[thekaveman]

Fixed in #135.

Thank you @rsh-raj for the original report and @jonathanraesch for the PR/fix!

• PyPI: https://pypi.org/project/conventional-pre-commit/4.2.0/
• GitHub: https://github.com/compilerla/conventional-pre-commit/releases/tag/v4.2.0