Reduce redundant logs when OAuth session is revoked

Author: EhabY

src/deployment/deploymentManager.ts

@@ -127,6 +127,7 @@ export class DeploymentManager implements vscode.Disposable {
 		// Register auth listener before setDeployment so background token refresh
 		// can update client credentials via the listener
 		this.registerAuthListener();
+		// Contexts must be set before refresh (providers check isAuthenticated)
 		this.updateAuthContexts(deployment.user);
 		this.refreshWorkspaces();
 

src/extension.ts

@@ -124,10 +124,13 @@ export async function activate(ctx: vscode.ExtensionContext): Promise<void> {
 	);
 	ctx.subscriptions.push(authInterceptor);
 
+	const isAuthenticated = () => contextManager.get("coder.authenticated");
+
 	const myWorkspacesProvider = new WorkspaceProvider(
 		WorkspaceQuery.Mine,
 		client,
 		output,
+		isAuthenticated,
 		5,
 	);
 	ctx.subscriptions.push(myWorkspacesProvider);
@@ -136,6 +139,7 @@ export async function activate(ctx: vscode.ExtensionContext): Promise<void> {
 		WorkspaceQuery.All,
 		client,
 		output,
+		isAuthenticated,
 	);
 	ctx.subscriptions.push(allWorkspacesProvider);
 
@@ -316,11 +320,10 @@ export async function activate(ctx: vscode.ExtensionContext): Promise<void> {
 		output.info(`Initializing deployment: ${deployment.url}`);
 		deploymentManager
 			.setDeploymentIfValid(deployment)
+			// Failure is logged internally
 			.then((success) => {
 				if (success) {
 					output.info("Deployment authenticated and set");
-				} else {
-					output.info("Failed to authenticate, deployment not set");
 				}
 			})
 			.catch((error: unknown) => {

src/workspace/workspacesProvider.ts

@@ -50,6 +50,7 @@ export class WorkspaceProvider
 		private readonly getWorkspacesQuery: WorkspaceQuery,
 		private readonly client: CoderApi,
 		private readonly logger: Logger,
+		private readonly isAuthenticated: () => boolean,
 		private readonly timerSeconds?: number,
 	) {
 		// No initialization.
@@ -61,7 +62,12 @@ export class WorkspaceProvider
 	// Calling this while already refreshing or not visible is a no-op and will
 	// return immediately.
 	public async fetchAndRefresh() {
-		if (this.disposed || this.fetching || !this.visible) {
+		if (
+			this.disposed ||
+			this.fetching ||
+			!this.visible ||
+			!this.isAuthenticated()
+		) {
 			return;
 		}
 		this.fetching = true;