ci: added IT tests

Author: quintesse

.github/workflows/ci.yml

@@ -26,3 +26,17 @@ jobs:
 
       - name: Build and verify
         run: ./mvnw --no-transfer-progress --batch-mode verify
+
+      - name: Run IT tests
+        shell: bash
+        run: |
+          MVN="./mvnw --no-transfer-progress --batch-mode verify -DskipITs=false -Dsurefire.skip=true"
+          if [[ "$RUNNER_OS" == "Linux" ]]; then
+            # Allocate a PTY so /dev/tty is available for the Terminal IT tests
+            script -q -e -c "$MVN" /dev/null
+          elif [[ "$RUNNER_OS" == "macOS" ]]; then
+            # BSD script: command args follow the output file
+            script -q /dev/null $MVN
+          else
+            $MVN
+          fi

miniterm-ffm/pom.xml

@@ -107,6 +107,22 @@
                     <argLine>--enable-native-access=ALL-UNNAMED</argLine>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-failsafe-plugin</artifactId>
+                <configuration>
+                    <argLine>--enable-native-access=ALL-UNNAMED</argLine>
+                    <forkCount>0</forkCount>
+                </configuration>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>integration-test</goal>
+                            <goal>verify</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
             <plugin>
                 <groupId>com.diffplug.spotless</groupId>
                 <artifactId>spotless-maven-plugin</artifactId>

miniterm-ffm/src/main/java/org/codejive/miniterm/windows/FfmWindowsTerminal.java

@@ -33,8 +33,8 @@ public final class FfmWindowsTerminal implements Terminal {
     private final MemorySegment inputRecord;
     private final MemorySegment intBuffer;
 
-    private final int savedInputMode;
-    private final int savedOutputMode;
+    private int savedInputMode;
+    private int savedOutputMode;
     private boolean rawModeEnabled;
     private volatile Consumer<Size> resizeHandler;
 
@@ -59,28 +59,26 @@ public FfmWindowsTerminal() throws IOException {
         inputRecord = arena.allocate(Kernel32.INPUT_RECORD_LAYOUT);
         intBuffer = arena.allocate(ValueLayout.JAVA_INT);
 
+        rawModeEnabled = false;
+    }
+
+    @Override
+    public void enableRawMode() throws IOException {
+        if (rawModeEnabled) {
+            return;
+        }
+
         // Save original console modes
         if (Kernel32.getConsoleMode(inputHandle, intBuffer) == 0) {
-            arena.close();
             throw new RuntimeException("Failed to get input console mode");
         }
         savedInputMode = intBuffer.get(ValueLayout.JAVA_INT, 0);
 
         if (Kernel32.getConsoleMode(outputHandle, intBuffer) == 0) {
-            arena.close();
             throw new RuntimeException("Failed to get output console mode");
         }
         savedOutputMode = intBuffer.get(ValueLayout.JAVA_INT, 0);
 
-        rawModeEnabled = false;
-    }
-
-    @Override
-    public void enableRawMode() throws IOException {
-        if (rawModeEnabled) {
-            return;
-        }
-
         // Set input mode: disable line input, echo, and processed input; enable VT input
         var newInputMode =
                 savedInputMode

miniterm-ffm/src/test/java/org/codejive/miniterm/TerminalIT.java

@@ -0,0 +1,25 @@
+/*
+ * Copyright TamboUI and miniterm Contributors
+ * SPDX-License-Identifier: MIT
+ */
+package org.codejive.miniterm;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.IOException;
+import org.junit.jupiter.api.Test;
+
+class TerminalIT {
+
+    @Test
+    void terminalCanBeCreatedAndClosed() throws IOException {
+        Terminal terminal = Terminal.create();
+        try {
+            assertThat(terminal).isNotNull();
+            assertThat(terminal.charset()).isNotNull();
+            assertThat(terminal.rawModeEnabled()).isFalse();
+        } finally {
+            terminal.close();
+        }
+    }
+}

miniterm/pom.xml

@@ -80,6 +80,18 @@
                     </archive>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-failsafe-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>integration-test</goal>
+                            <goal>verify</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
             <plugin>
                 <groupId>com.diffplug.spotless</groupId>
                 <artifactId>spotless-maven-plugin</artifactId>
@@ -244,6 +256,25 @@
                 </plugins>
             </build>
         </profile>
+        <profile>
+            <id>macos-it</id>
+            <activation>
+                <os><family>mac</family></os>
+            </activation>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-failsafe-plugin</artifactId>
+                        <configuration>
+                            <!-- On macOS the forked JVM's stdin is a pipe, not a TTY.
+                                 Running in-process avoids the fork so /dev/stdin remains a PTY. -->
+                            <forkCount>0</forkCount>
+                        </configuration>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
     </profiles>
 
 </project>

miniterm/src/test/java/org/codejive/miniterm/TerminalIT.java

@@ -0,0 +1,25 @@
+/*
+ * Copyright TamboUI and miniterm Contributors
+ * SPDX-License-Identifier: MIT
+ */
+package org.codejive.miniterm;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.IOException;
+import org.junit.jupiter.api.Test;
+
+class TerminalIT {
+
+    @Test
+    void terminalCanBeCreatedAndClosed() throws IOException {
+        Terminal terminal = Terminal.create();
+        try {
+            assertThat(terminal).isNotNull();
+            assertThat(terminal.charset()).isNotNull();
+            assertThat(terminal.rawModeEnabled()).isFalse();
+        } finally {
+            terminal.close();
+        }
+    }
+}

pom.xml

@@ -46,6 +46,7 @@
 
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <skipITs>true</skipITs>
 
         <!-- Dependency versions -->
         <version.jspecify>1.0.0</version.jspecify>
@@ -99,6 +100,11 @@
                     <artifactId>maven-surefire-plugin</artifactId>
                     <version>3.5.5</version>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-failsafe-plugin</artifactId>
+                    <version>3.5.5</version>
+                </plugin>
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-jar-plugin</artifactId>