refactor: compare $db->connID to false (#9891)

paulbalandan · web-flow · commit 6cd74bf7cd8c · 2026-01-18T17:38:21.000+08:00
diff --git a/system/Database/Database.php b/system/Database/Database.php
@@ -70,7 +70,7 @@ public function load(array $params = [], string $alias = '')
      */
     public function loadForge(ConnectionInterface $db): Forge
     {
-        if (! $db->connID) {
+        if ($db->connID === false) {
             $db->initialize();
         }
 
@@ -84,7 +84,7 @@ public function loadForge(ConnectionInterface $db): Forge
      */
     public function loadUtils(ConnectionInterface $db): BaseUtils
     {
-        if (! $db->connID) {
+        if ($db->connID === false) {
             $db->initialize();
         }
 
diff --git a/utils/phpstan-baseline/booleanNot.exprNotBoolean.neon b/utils/phpstan-baseline/booleanNot.exprNotBoolean.neon
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -1,10 +1,9 @@
-# total 2168 errors
+# total 2166 errors
 
 includes:
     - argument.type.neon
     - arguments.count.neon
     - assign.propertyType.neon
-    - booleanNot.exprNotBoolean.neon
     - codeigniter.getReassignArray.neon
     - codeigniter.modelArgumentType.neon
     - codeigniter.superglobalAccess.neon

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public function load(array $params = [], string $alias = '')`
`70`	`70`	`*/`
`71`	`71`	`public function loadForge(ConnectionInterface $db): Forge`
`72`	`72`	`{`
`73`		`- if (! $db->connID) {`
	`73`	`+ if ($db->connID === false) {`
`74`	`74`	`$db->initialize();`
`75`	`75`	`}`
`76`	`76`
`@@ -84,7 +84,7 @@ public function loadForge(ConnectionInterface $db): Forge`
`84`	`84`	`*/`
`85`	`85`	`public function loadUtils(ConnectionInterface $db): BaseUtils`
`86`	`86`	`{`
`87`		`- if (! $db->connID) {`
	`87`	`+ if ($db->connID === false) {`
`88`	`88`	`$db->initialize();`
`89`	`89`	`}`
`90`	`90`