Skip to content

Commit 87ae75b

Browse files
authored
[Perf Tracks] Use minus (-) instead of en dash for removed props (facebook#35649)
1 parent ff191f2 commit 87ae75b

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ describe('ReactPerformanceTracks', () => {
231231
properties: [
232232
['Changed Props', ''],
233233
['  data', ''],
234-
['   buffer', 'null'],
234+
['-   buffer', 'null'],
235235
['+   buffer', 'Uint8Array'],
236236
['+     0', '0'],
237237
['+     1', '0'],
@@ -422,7 +422,7 @@ describe('ReactPerformanceTracks', () => {
422422
color: 'error',
423423
properties: [
424424
['Changed Props', ''],
425-
[' value', '1'],
425+
['- value', '1'],
426426
['+ value', '2'],
427427
],
428428
tooltipText: 'Left',
@@ -510,7 +510,7 @@ describe('ReactPerformanceTracks', () => {
510510
['  data', ''],
511511
['    deeply', ''],
512512
['      nested', ''],
513-
['       numbers', 'Array'],
513+
['-       numbers', 'Array'],
514514
['+       numbers', 'Array'],
515515
],
516516
tooltipText: 'App',

packages/shared/ReactPerformanceTrackProperties.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ export function addValueToProperties(
279279
properties.push([prefix + '\xa0\xa0'.repeat(indent) + propertyName, desc]);
280280
}
281281

282-
const REMOVED = '\u2013\xa0';
282+
const REMOVED = '-\xa0';
283283
const ADDED = '+\xa0';
284284
const UNCHANGED = '\u2007\xa0';
285285

0 commit comments

Comments
 (0)