Skip to content

Commit b4018e3

Browse files
kycutlerCopilot
andauthored
Never use simple browser on desktop (microsoft#303312)
* Never use simple browser on desktop * Update extensions/simple-browser/package.nls.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent caef4ed commit b4018e3

3 files changed

Lines changed: 9 additions & 15 deletions

File tree

extensions/simple-browser/package.json

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,14 @@
4242
"category": "Simple Browser"
4343
}
4444
],
45+
"menus": {
46+
"commandPalette": [
47+
{
48+
"command": "simpleBrowser.show",
49+
"when": "isWeb"
50+
}
51+
]
52+
},
4553
"configuration": [
4654
{
4755
"title": "Simple Browser",
@@ -51,12 +59,6 @@
5159
"default": true,
5260
"title": "Focus Lock Indicator Enabled",
5361
"description": "%configuration.focusLockIndicator.enabled.description%"
54-
},
55-
"simpleBrowser.useIntegratedBrowser": {
56-
"type": "boolean",
57-
"default": true,
58-
"markdownDescription": "%configuration.useIntegratedBrowser.description%",
59-
"scope": "application"
6062
}
6163
}
6264
}
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"displayName": "Simple Browser",
33
"description": "A very basic built-in webview for displaying web content.",
4-
"configuration.focusLockIndicator.enabled.description": "Enable/disable the floating indicator that shows when focused in the simple browser.",
5-
"configuration.useIntegratedBrowser.description": "When enabled, the `simpleBrowser.show` command will open URLs in the integrated browser instead of the Simple Browser webview. **Note:** This setting is only available on desktop."
4+
"configuration.focusLockIndicator.enabled.description": "Enable/disable the floating indicator that shows when focused in the simple browser."
65
}

extensions/simple-browser/src/extension.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ declare class URL {
1515
const openApiCommand = 'simpleBrowser.api.open';
1616
const showCommand = 'simpleBrowser.show';
1717
const integratedBrowserCommand = 'workbench.action.browser.open';
18-
const useIntegratedBrowserSetting = 'simpleBrowser.useIntegratedBrowser';
1918

2019
const enabledHosts = new Set<string>([
2120
'localhost',
@@ -37,12 +36,6 @@ const openerId = 'simpleBrowser.open';
3736
* Checks if the integrated browser should be used instead of the simple browser
3837
*/
3938
async function shouldUseIntegratedBrowser(): Promise<boolean> {
40-
const config = vscode.workspace.getConfiguration();
41-
if (!config.get<boolean>(useIntegratedBrowserSetting, true)) {
42-
return false;
43-
}
44-
45-
// Verify that the integrated browser command is available
4639
const commands = await vscode.commands.getCommands(true);
4740
return commands.includes(integratedBrowserCommand);
4841
}

0 commit comments

Comments
 (0)