Merge pull request microsoft#300562 from mjbvz/dev/mjbvz/tragic-tyrannosaurus

Log when `untitled` sessions cross the ext host boundary

Author: mjbvz

src/vs/workbench/api/browser/mainThreadChatSessions.ts

@@ -27,6 +27,7 @@ import { IChatContentInlineReference, IChatProgress, IChatService, ResponseModel
 import { ChatSessionStatus, IChatSession, IChatSessionContentProvider, IChatSessionHistoryItem, IChatSessionItem, IChatSessionItemController, IChatSessionProviderOptionItem, IChatSessionsService } from '../../contrib/chat/common/chatSessionsService.js';
 import { ChatAgentLocation } from '../../contrib/chat/common/constants.js';
 import { IChatModel } from '../../contrib/chat/common/model/chatModel.js';
+import { isUntitledChatSession } from '../../contrib/chat/common/model/chatUri.js';
 import { IChatAgentRequest } from '../../contrib/chat/common/participants/chatAgents.js';
 import { IChatTodoListService } from '../../contrib/chat/common/tools/chatTodoListService.js';
 import { IEditorGroupsService } from '../../services/editor/common/editorGroupsService.js';
@@ -350,6 +351,8 @@ class MainThreadChatSessionItemController extends Disposable implements IChatSes
 	}
 
 	async newChatSessionItem(request: IChatAgentRequest, token: CancellationToken): Promise<IChatSessionItem | undefined> {
+		warnOnUntitledSessionResource(request.sessionResource);
+
 		const dto = await raceCancellationError(this._proxy.$newChatSessionItem(this._handle, request, token), token);
 		if (!dto) {
 			return undefined;
@@ -366,6 +369,7 @@ class MainThreadChatSessionItemController extends Disposable implements IChatSes
 
 	acceptChange(change: { readonly addedOrUpdated: readonly IChatSessionItem[]; readonly removed: readonly URI[] }): void {
 		for (const item of change.addedOrUpdated) {
+			warnOnUntitledSessionResource(item.resource);
 			this._items.set(item.resource, item);
 		}
 		for (const uri of change.removed) {
@@ -375,6 +379,7 @@ class MainThreadChatSessionItemController extends Disposable implements IChatSes
 	}
 
 	addOrUpdateItem(item: IChatSessionItem): void {
+		warnOnUntitledSessionResource(item.resource);
 		this._items.set(item.resource, item);
 		this._onDidChangeChatSessionItems.fire();
 	}
@@ -384,6 +389,7 @@ class MainThreadChatSessionItemController extends Disposable implements IChatSes
 	}
 }
 
+
 @extHostNamedCustomer(MainContext.MainThreadChatSessions)
 export class MainThreadChatSessions extends Disposable implements MainThreadChatSessionsShape {
 	private readonly _itemControllerRegistrations = this._register(new DisposableMap<number, IDisposable & {
@@ -415,6 +421,7 @@ export class MainThreadChatSessions extends Disposable implements MainThreadChat
 		this._proxy = this._extHostContext.getProxy(ExtHostContext.ExtHostChatSessions);
 
 		this._register(this._chatSessionsService.onRequestNotifyExtension(({ sessionResource, updates, waitUntil }) => {
+			warnOnUntitledSessionResource(sessionResource);
 			const handle = this._getHandleForSessionType(sessionResource.scheme);
 			this._logService.trace(`[MainThreadChatSessions] onRequestNotifyExtension received: scheme '${sessionResource.scheme}', handle ${handle}, ${updates.length} update(s)`);
 			if (handle !== undefined) {
@@ -427,6 +434,7 @@ export class MainThreadChatSessions extends Disposable implements MainThreadChat
 		this._register(this._agentSessionsService.model.onDidChangeSessionArchivedState(session => {
 			for (const [handle, { chatSessionType }] of this._itemControllerRegistrations) {
 				if (chatSessionType === session.providerType) {
+					warnOnUntitledSessionResource(session.resource);
 					this._proxy.$onDidChangeChatSessionItemState(handle, session.resource, session.isArchived());
 				}
 			}
@@ -515,6 +523,7 @@ export class MainThreadChatSessions extends Disposable implements MainThreadChat
 
 	$onDidChangeChatSessionOptions(handle: number, sessionResourceComponents: UriComponents, updates: ReadonlyArray<{ optionId: string; value: string }>): void {
 		const sessionResource = URI.revive(sessionResourceComponents);
+		warnOnUntitledSessionResource(sessionResource);
 		this._chatSessionsService.notifySessionOptionsChange(sessionResource, updates);
 	}
 
@@ -622,6 +631,8 @@ export class MainThreadChatSessions extends Disposable implements MainThreadChat
 	}
 
 	private async _provideChatSessionContent(providerHandle: number, sessionResource: URI, token: CancellationToken): Promise<IChatSession> {
+		warnOnUntitledSessionResource(sessionResource);
+
 		let session = this._activeSessions.get(sessionResource);
 
 		if (!session) {
@@ -711,6 +722,8 @@ export class MainThreadChatSessions extends Disposable implements MainThreadChat
 
 	$handleProgressComplete(handle: number, sessionResource: UriComponents, requestId: string) {
 		const resource = URI.revive(sessionResource);
+		warnOnUntitledSessionResource(resource);
+
 		const observableSession = this._activeSessions.get(resource);
 		if (!observableSession) {
 			this._logService.warn(`No session found for progress completion: handle ${handle}, sessionResource ${resource}, requestId ${requestId}`);
@@ -803,3 +816,9 @@ export class MainThreadChatSessions extends Disposable implements MainThreadChat
 		}
 	}
 }
+
+function warnOnUntitledSessionResource(resource: URI): void {
+	if (isUntitledChatSession(resource)) {
+		console.trace(`[MainThreadChatSessions] untitled-style sessionResource detected ${resource.toString()}`);
+	}
+}