refactor(create-cli): pass single input to generateConfig

Author: hanna-skryl

packages/create-cli/src/lib/setup/types.ts

@@ -5,6 +5,7 @@ export type {
   CategoryCodegenConfig,
   ImportDeclarationStructure,
   PluginAnswer,
+  PluginCodegenInput,
   PluginCodegenResult,
   PluginPromptDescriptor,
   PluginSetupBinding,

packages/create-cli/src/lib/setup/wizard.ts

@@ -93,7 +93,12 @@ async function resolveBinding(
   tree: Pick<Tree, 'read' | 'write'>,
 ): Promise<PluginCodegenResult> {
   if (!binding.prompts) {
-    return binding.generateConfig({}, tree);
+    return binding.generateConfig({
+      tree,
+      targetDir,
+      cliArgs,
+      answers: {},
+    });
   }
   logger.newline();
   logger.info(ansis.bold(binding.title));
@@ -102,7 +107,7 @@ async function resolveBinding(
     descriptors.length > 0
       ? await promptPluginOptions(descriptors, cliArgs)
       : {};
-  return binding.generateConfig(answers, tree);
+  return binding.generateConfig({ tree, targetDir, cliArgs, answers });
 }
 
 async function writeStandaloneConfig(

packages/models/src/index.ts

@@ -116,6 +116,7 @@ export type {
   CategoryCodegenConfig,
   ImportDeclarationStructure,
   PluginAnswer,
+  PluginCodegenInput,
   PluginCodegenResult,
   PluginDeclarationStructure,
   PluginPromptDescriptor,

packages/models/src/lib/plugin-setup.ts

@@ -72,6 +72,13 @@ export type PluginSetupTree = {
   write: (path: string, content: string) => Promise<void>;
 };
 
+export type PluginCodegenInput = {
+  answers: Record<string, PluginAnswer>;
+  tree: PluginSetupTree;
+  targetDir: string;
+  cliArgs: Record<string, unknown>;
+};
+
 /**
  * Defines how a plugin integrates with the setup wizard.
  *
@@ -88,7 +95,6 @@ export type PluginSetupBinding = {
   prompts?: (targetDir: string) => Promise<PluginPromptDescriptor[]>;
   isRecommended?: (targetDir: string) => Promise<boolean>;
   generateConfig: (
-    answers: Record<string, PluginAnswer>,
-    tree: PluginSetupTree,
+    input: PluginCodegenInput,
   ) => PluginCodegenResult | Promise<PluginCodegenResult>;
 };

packages/plugin-axe/src/lib/binding.ts

@@ -3,7 +3,6 @@ import type {
   CategoryCodegenConfig,
   PluginAnswer,
   PluginSetupBinding,
-  PluginSetupTree,
 } from '@code-pushup/models';
 import {
   answerBoolean,
@@ -84,10 +83,7 @@ export const axeSetupBinding = {
       default: true,
     },
   ],
-  generateConfig: async (
-    answers: Record<string, PluginAnswer>,
-    tree: PluginSetupTree,
-  ) => {
+  generateConfig: async ({ answers, tree }) => {
     const options = parseAnswers(answers);
     if (options.setupScript) {
       await tree.write(SETUP_SCRIPT_PATH, SETUP_SCRIPT_CONTENT);

packages/plugin-coverage/src/lib/binding.ts

@@ -128,10 +128,7 @@ export const coverageSetupBinding = {
       },
     ];
   },
-  generateConfig: async (
-    answers: Record<string, PluginAnswer>,
-    tree?: PluginSetupTree,
-  ) => {
+  generateConfig: async ({ answers, tree }) => {
     const options = parseAnswers(answers);
     const lcovConfigured = await configureLcovReporter(options, tree);
     return {

packages/plugin-eslint/src/lib/binding.ts

@@ -90,7 +90,7 @@ export const eslintSetupBinding = {
       default: true,
     },
   ],
-  generateConfig: (answers: Record<string, PluginAnswer>) => {
+  generateConfig: ({ answers }) => {
     const options = parseAnswers(answers);
     return {
       imports: [

packages/plugin-js-packages/src/lib/binding.ts

@@ -105,7 +105,7 @@ export const jsPackagesSetupBinding = {
       },
     ];
   },
-  generateConfig: (answers: Record<string, PluginAnswer>) => {
+  generateConfig: ({ answers }) => {
     const options = parseAnswers(answers);
     return {
       imports: [

packages/plugin-jsdocs/src/lib/binding.ts

@@ -60,7 +60,7 @@ export const jsDocsSetupBinding = {
       default: true,
     },
   ],
-  generateConfig: (answers: Record<string, PluginAnswer>) => {
+  generateConfig: ({ answers }) => {
     const options = parseAnswers(answers);
     return {
       imports: [

packages/plugin-lighthouse/src/lib/binding.ts

@@ -80,7 +80,7 @@ export const lighthouseSetupBinding = {
       default: CATEGORIES.map(({ slug }) => slug),
     },
   ],
-  generateConfig: (answers: Record<string, PluginAnswer>) => {
+  generateConfig: ({ answers }) => {
     const options = parseAnswers(answers);
     const hasCategories = options.categories.length > 0;
     const imports = [