fix(plugin-axe): resolve ESLint errors and warnings

Author: hanna-skryl

packages/plugin-axe/src/lib/config.ts

@@ -5,14 +5,16 @@ import {
 } from '@code-pushup/models';
 import { AXE_DEFAULT_PRESET, AXE_PRESETS } from './constants.js';
 
+const DEFAULT_TIMEOUT_MS = 30_000;
+
 export const axePluginOptionsSchema = z
   .object({
     preset: z.enum(AXE_PRESETS).default(AXE_DEFAULT_PRESET).meta({
       description:
         'Accessibility ruleset preset (default: wcag21aa for WCAG 2.1 Level AA compliance)',
     }),
     scoreTargets: pluginScoreTargetsSchema.optional(),
-    timeout: positiveIntSchema.default(30_000).meta({
+    timeout: positiveIntSchema.default(DEFAULT_TIMEOUT_MS).meta({
       description:
         'Page navigation timeout in milliseconds (default: 30000ms / 30s)',
     }),

packages/plugin-axe/src/lib/config.unit.test.ts

@@ -1,4 +1,5 @@
 import { describe, expect, it } from 'vitest';
+import { ZodError } from 'zod';
 import { axePluginOptionsSchema } from './config.js';
 
 describe('axePluginOptionsSchema', () => {
@@ -31,17 +32,21 @@ describe('axePluginOptionsSchema', () => {
   });
 
   it('should reject invalid preset values', () => {
-    expect(() => axePluginOptionsSchema.parse({ preset: 'wcag3aa' })).toThrow();
+    expect(() => axePluginOptionsSchema.parse({ preset: 'wcag3aa' })).toThrow(
+      ZodError,
+    );
   });
 
   it('should reject scoreTargets values greater than 1', () => {
-    expect(() => axePluginOptionsSchema.parse({ scoreTargets: 1.5 })).toThrow();
+    expect(() => axePluginOptionsSchema.parse({ scoreTargets: 1.5 })).toThrow(
+      ZodError,
+    );
   });
 
   it('should reject negative scoreTargets', () => {
-    expect(() =>
-      axePluginOptionsSchema.parse({ scoreTargets: -0.1 }),
-    ).toThrow();
+    expect(() => axePluginOptionsSchema.parse({ scoreTargets: -0.1 })).toThrow(
+      ZodError,
+    );
   });
 
   it('should accept custom timeout value', () => {
@@ -51,11 +56,17 @@ describe('axePluginOptionsSchema', () => {
   });
 
   it('should reject non-positive timeout values', () => {
-    expect(() => axePluginOptionsSchema.parse({ timeout: 0 })).toThrow();
-    expect(() => axePluginOptionsSchema.parse({ timeout: -1000 })).toThrow();
+    expect(() => axePluginOptionsSchema.parse({ timeout: 0 })).toThrow(
+      ZodError,
+    );
+    expect(() => axePluginOptionsSchema.parse({ timeout: -1000 })).toThrow(
+      ZodError,
+    );
   });
 
   it('should reject non-integer timeout values', () => {
-    expect(() => axePluginOptionsSchema.parse({ timeout: 1000.5 })).toThrow();
+    expect(() => axePluginOptionsSchema.parse({ timeout: 1000.5 })).toThrow(
+      ZodError,
+    );
   });
 });

packages/plugin-axe/src/lib/meta/groups.unit.test.ts

@@ -77,7 +77,7 @@ describe('transformRulesToGroups', () => {
       'best-practice',
     );
 
-    expect(groups).toSatisfyAll<Group>(({ slug }) => !slug.match(/^cat\./));
+    expect(groups).toSatisfyAll<Group>(({ slug }) => !/^cat\./.test(slug));
   });
 
   it('should include both WCAG 2.2 and category groups for "all" preset', () => {

packages/plugin-axe/src/lib/meta/transform.ts

@@ -47,6 +47,7 @@ export function transformRulesToGroups(
         return createWcagGroups(rules, '2.1');
       case 'wcag22aa':
         return createWcagGroups(rules, '2.2');
+      // eslint-disable-next-line sonarjs/no-duplicate-string
       case 'best-practice':
         return createCategoryGroups(rules);
       case 'all':
@@ -128,7 +129,7 @@ function createCategoryGroups(rules: axe.RuleMetadata[]): Group[] {
     rules.flatMap(({ tags }) => tags.filter(tag => tag.startsWith('cat.'))),
   );
 
-  return Array.from(categoryTags).map(tag => {
+  return [...categoryTags].map(tag => {
     const slug = tag.replace('cat.', '');
     const title = formatCategoryTitle(tag, slug);
     const categoryRules = rules.filter(({ tags }) => tags.includes(tag));

packages/plugin-axe/src/lib/processing.unit.test.ts

@@ -1,5 +1,5 @@
 import { describe, expect, it } from 'vitest';
-import { processAuditsAndGroups } from './processing';
+import { processAuditsAndGroups } from './processing.js';
 
 describe('processAuditsAndGroups', () => {
   it('should return audits and groups without expansion when analyzing single URL', () => {

packages/plugin-axe/src/lib/runner/transform.ts

@@ -1,5 +1,4 @@
-import type { AxeResults, ImpactValue, NodeResult, Result } from 'axe-core';
-import type axe from 'axe-core';
+import axe from 'axe-core';
 import type {
   AuditOutput,
   AuditOutputs,
@@ -18,7 +17,7 @@ import {
  * Priority: violations > incomplete > passes > inapplicable
  */
 export function toAuditOutputs(
-  { passes, violations, incomplete, inapplicable }: AxeResults,
+  { passes, violations, incomplete, inapplicable }: axe.AxeResults,
   url: string,
 ): AuditOutputs {
   const auditMap = new Map<string, AuditOutput>([
@@ -28,15 +27,15 @@ export function toAuditOutputs(
     ...violations.map(res => [res.id, toAuditOutput(res, url, 0)] as const),
   ]);
 
-  return Array.from(auditMap.values());
+  return [...auditMap.values()];
 }
 
 /**
  * For failing audits (score 0), includes detailed issues with locations and severities.
  * For passing audits (score 1), only includes element count.
  */
 function toAuditOutput(
-  result: Result,
+  result: axe.Result,
   url: string,
   score: number,
 ): AuditOutput {
@@ -69,7 +68,7 @@ function formatSelector(selector: axe.CrossTreeSelector): string {
   return selector.join(' >> ');
 }
 
-function toIssue(node: NodeResult, result: Result, url: string): Issue {
+function toIssue(node: axe.NodeResult, result: axe.Result, url: string): Issue {
   const selector = formatSelector(node.target?.[0] || node.html);
   const rawMessage = node.failureSummary || result.help;
   const cleanedMessage = rawMessage.replace(/\s+/g, ' ').trim();
@@ -82,7 +81,7 @@ function toIssue(node: NodeResult, result: Result, url: string): Issue {
   };
 }
 
-function impactToSeverity(impact: ImpactValue | undefined): IssueSeverity {
+function impactToSeverity(impact: axe.ImpactValue | undefined): IssueSeverity {
   switch (impact) {
     case 'critical':
     case 'serious':

packages/plugin-axe/src/lib/runner/transform.unit.test.ts

@@ -287,7 +287,7 @@ describe('toAuditOutputs', () => {
           issues: [
             {
               message:
-                '[`<div role=\"invalid-role\">Content</div>`] Fix this: Ensure all values assigned to role=\"\" correspond to valid ARIA roles ([example.com](https://example.com))',
+                '[`<div role="invalid-role">Content</div>`] Fix this: Ensure all values assigned to role="" correspond to valid ARIA roles ([example.com](https://example.com))',
               severity: 'error',
             },
           ],