refactor: move objToCliArgs parts and reuse

Author: John Doe

packages/nx-plugin/src/executors/cli/executor.ts

@@ -1,6 +1,5 @@
 import { type ExecutorContext } from '@nx/devkit';
 import { executeProcess } from '../../internal/execute-process.js';
-import { objectToCliArgs } from '../internal/cli.js';
 import type { AutorunCommandExecutorOptions } from './schema.js';
 
 export type ExecutorOutput = {
@@ -13,6 +12,9 @@ export default async function runAutorunExecutor(
   terminalAndExecutorOptions: AutorunCommandExecutorOptions,
   { cwd }: ExecutorContext,
 ): Promise<ExecutorOutput> {
+  const { logger, stringifyError, formatCommand, objectToCliArgs } =
+    await import('@code-pushup/utils');
+
   const {
     dryRun,
     verbose,
@@ -21,6 +23,7 @@ export default async function runAutorunExecutor(
     bin,
     ...argsObj
   } = terminalAndExecutorOptions;
+
   const command = bin ? `node` : 'npx';
   const positionals = [
     bin ?? '@code-pushup/cli',
@@ -32,9 +35,6 @@ export default async function runAutorunExecutor(
     ...(verbose && { CP_VERBOSE: 'true' }),
   };
 
-  const { logger, stringifyError, formatCommand } = await import(
-    '@code-pushup/utils'
-  );
   const binString = `${command} ${positionals.join(' ')} ${args.join(' ')}`;
   const formattedBinString = formatCommand(binString, {
     env: envVariables,

packages/nx-plugin/src/executors/internal/cli.ts

@@ -102,6 +102,10 @@ export function objectToCliArgs<
       return [`${prefix}${value ? '' : 'no-'}${key}`];
     }
 
+    if (value === null || value === undefined) {
+      return [];
+    }
+
     throw new Error(`Unsupported type ${typeof value} for key ${key}`);
   });
 }

packages/nx-plugin/src/executors/internal/cli.unit.test.ts

@@ -226,6 +226,12 @@ describe('objectToCliArgs', () => {
     ]);
   });
 
+  it('should handle objects with undefined', () => {
+    const params = { format: undefined };
+    const result = objectToCliArgs(params);
+    expect(result).toStrictEqual([]);
+  });
+
   it('should throw error for unsupported type', () => {
     const params = { unsupported: undefined as any };
     expect(() => objectToCliArgs(params)).toThrow('Unsupported type');