Skip to content

Commit c1cff7b

Browse files
committed
fix: adjust plugin options for audits
1 parent 7683533 commit c1cff7b

File tree

9 files changed

+1364
-1358
lines changed

9 files changed

+1364
-1358
lines changed

code-pushup.config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,5 @@ export default mergeConfigs(
4646
await eslintCoreConfigNx(),
4747
await typescriptPluginConfigNx({
4848
tsConfigPath: 'packages/plugin-typescript/tsconfig.lib.json',
49-
tsAudits: ['stris'],
5049
}),
5150
);

code-pushup.preset.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,8 @@ export const typescriptPluginConfigNx = async (
141141
options: TypescriptPluginOptions,
142142
): Promise<CoreConfig> => {
143143
const opt: TypescriptPluginOptions = {
144-
tsAudits: Object.values(SUPPORTED_TS_ERROR_CODES) as AuditSlug[],
144+
onlyAudits: Object.values(SUPPORTED_TS_ERROR_CODES) as (string &
145+
AuditSlug)[],
145146
...options,
146147
};
147148

@@ -151,7 +152,7 @@ export const typescriptPluginConfigNx = async (
151152
{
152153
slug: 'typescript',
153154
title: 'Typescript',
154-
refs: AUDITS.filter(filterAuditsBySlug(opt.tsAudits)).map(
155+
refs: AUDITS.filter(filterAuditsBySlug(opt.onlyAudits)).map(
155156
({ slug }) => ({
156157
plugin: 'typescript',
157158
type: 'audit' as const,
Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
import { z } from 'zod';
2+
import { AUDITS } from './generated/audits.js';
23
import type { AuditSlug } from './types.js';
34

5+
const auditSlugs = AUDITS.map(({ slug }) => slug) as [string, ...string[]];
46
export const typescriptPluginConfigSchema = z.object({
57
tsConfigPath: z.string().describe('Path to the TsConfig'),
6-
tsAudits: z
7-
.array(z.string())
8+
onlyAudits: z
9+
.enum(auditSlugs)
810
.optional()
911
.describe('Array with specific TsCodes to measure'),
1012
});
1113

1214
export type TypescriptPluginOptions = z.infer<
1315
typeof typescriptPluginConfigSchema
14-
> & { tsAudits?: AuditSlug[] | undefined };
16+
> & { onlyAudits?: AuditSlug[] | undefined };

packages/plugin-typescript/src/lib/constants.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import type { AuditSlug } from './types.js';
2+
13
export const TYPESCRIPT_PLUGIN_SLUG = 'typescript';
24

35
/* eslint-disable @typescript-eslint/no-magic-numbers */
@@ -62,11 +64,8 @@ export const SUPPORTED_TS_ERROR_CODES = {
6264
1063: 'export-assignment-error',
6365
1064: 'async-promise-type-error',
6466
1066: 'constant-enum-initializer-required',
65-
1085: 'syntax-error',
66-
1086: 'no-accessor-in-ambient',
6767
1089: 'invalid-constructor-modifier',
6868
1090: 'invalid-param-modifier',
69-
} as const;
69+
} as const satisfies Record<string, AuditSlug>;
7070

71-
export const BASIC_CHECKES = [2322, 2345, 2531];
7271
/* eslint-enable @typescript-eslint/no-magic-numbers */

0 commit comments

Comments
 (0)