Skip to content

Commit ad70ea9

Browse files
committed
feat(ci): do not skip nx cache for print-config and compare commands
1 parent ad9debf commit ad70ea9

File tree

4 files changed

+8
-26
lines changed

4 files changed

+8
-26
lines changed

packages/ci/src/lib/monorepo/handlers/nx.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export const nxHandler: MonorepoToolHandler = {
4141
const projects = parseProjects(stdout);
4242
return projects.toSorted().map(project => ({
4343
name: project,
44-
bin: `npx nx run ${project}:${task} --skip-nx-cache --`,
44+
bin: `npx nx run ${project}:${task} --`,
4545
}));
4646
},
4747

packages/ci/src/lib/monorepo/handlers/nx.unit.test.ts

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,8 @@ describe('nxHandler', () => {
5656

5757
it('should list projects from `nx show projects`', async () => {
5858
await expect(nxHandler.listProjects(options)).resolves.toEqual([
59-
{
60-
name: 'backend',
61-
bin: 'npx nx run backend:code-pushup --skip-nx-cache --',
62-
},
63-
{
64-
name: 'frontend',
65-
bin: 'npx nx run frontend:code-pushup --skip-nx-cache --',
66-
},
59+
{ name: 'backend', bin: 'npx nx run backend:code-pushup --' },
60+
{ name: 'frontend', bin: 'npx nx run frontend:code-pushup --' },
6761
] satisfies ProjectConfig[]);
6862
});
6963

@@ -125,14 +119,8 @@ describe('nxHandler', () => {
125119
describe('createRunManyCommand', () => {
126120
const projects: MonorepoHandlerProjectsContext = {
127121
all: [
128-
{
129-
name: 'backend',
130-
bin: 'npx nx run backend:code-pushup --skip-nx-cache --',
131-
},
132-
{
133-
name: 'frontend',
134-
bin: 'npx nx run frontend:code-pushup --skip-nx-cache --',
135-
},
122+
{ name: 'backend', bin: 'npx nx run backend:code-pushup --' },
123+
{ name: 'frontend', bin: 'npx nx run frontend:code-pushup --' },
136124
],
137125
};
138126

packages/ci/src/lib/monorepo/list-projects.unit.test.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,8 @@ describe('listMonorepoProjects', () => {
5858
await expect(listMonorepoProjects(MONOREPO_SETTINGS)).resolves.toEqual({
5959
tool: 'nx',
6060
projects: [
61-
{
62-
name: 'backend',
63-
bin: 'npx nx run backend:code-pushup --skip-nx-cache --',
64-
},
65-
{
66-
name: 'frontend',
67-
bin: 'npx nx run frontend:code-pushup --skip-nx-cache --',
68-
},
61+
{ name: 'backend', bin: 'npx nx run backend:code-pushup --' },
62+
{ name: 'frontend', bin: 'npx nx run frontend:code-pushup --' },
6963
],
7064
runManyCommand: expect.any(Function),
7165
} satisfies MonorepoProjects);

packages/ci/src/lib/run.integration.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,7 @@ describe('runInCI', () => {
534534
name: 'Nx',
535535
tool: 'nx',
536536
run: expect.stringMatching(
537-
/^npx nx run (cli|core|utils):code-pushup --skip-nx-cache --$/,
537+
/^npx nx run (cli|core|utils):code-pushup --$/,
538538
),
539539
runMany:
540540
'npx nx run-many --targets=code-pushup --parallel=false --projects=cli,core,utils --',

0 commit comments

Comments
 (0)