Skip to content

Commit a1732d4

Browse files
committed
refactor(plugin-eslint): fix int tests
1 parent 687bada commit a1732d4

File tree

2 files changed

+3
-34
lines changed

2 files changed

+3
-34
lines changed

packages/plugin-eslint/src/lib/__snapshots__/eslint-plugin.int.test.ts.snap

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -346,16 +346,7 @@ exports[`eslintPlugin > should initialize ESLint plugin for React application 1`
346346
],
347347
"icon": "eslint",
348348
"packageName": "@code-pushup/eslint-plugin",
349-
"runner": {
350-
"args": [
351-
""<dirname>/bin.js"",
352-
"--runnerConfigPath="node_modules/.code-pushup/eslint/<timestamp>/plugin-config.json"",
353-
"--runnerOutputPath="node_modules/.code-pushup/eslint/<timestamp>/runner-output.json"",
354-
],
355-
"command": "node",
356-
"configFile": "node_modules/.code-pushup/eslint/<timestamp>/plugin-config.json",
357-
"outputFile": "node_modules/.code-pushup/eslint/<timestamp>/runner-output.json",
358-
},
349+
"runner": [Function],
359350
"slug": "eslint",
360351
"title": "ESLint",
361352
"version": Any<String>,

packages/plugin-eslint/src/lib/eslint-plugin.int.test.ts

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ import path from 'node:path';
33
import process from 'node:process';
44
import { fileURLToPath } from 'node:url';
55
import type { MockInstance } from 'vitest';
6-
import type { Audit, PluginConfig, RunnerConfig } from '@code-pushup/models';
7-
import { toUnixPath } from '@code-pushup/utils';
6+
import type { Audit } from '@code-pushup/models';
87
import { eslintPlugin } from './eslint-plugin.js';
98

109
describe('eslintPlugin', () => {
@@ -15,27 +14,6 @@ describe('eslintPlugin', () => {
1514
let cwdSpy: MockInstance<[], string>;
1615
let platformSpy: MockInstance<[], NodeJS.Platform>;
1716

18-
const replaceAbsolutePath = (plugin: PluginConfig): PluginConfig => ({
19-
...plugin,
20-
runner: {
21-
...(plugin.runner as RunnerConfig),
22-
args: (plugin.runner as RunnerConfig).args?.map(arg =>
23-
toUnixPath(arg.replace(path.dirname(thisDir), '<dirname>')).replace(
24-
/\/eslint\/\d+\//,
25-
'/eslint/<timestamp>/',
26-
),
27-
),
28-
...((plugin.runner as RunnerConfig).configFile && {
29-
configFile: toUnixPath(
30-
(plugin.runner as RunnerConfig).configFile!,
31-
).replace(/\/eslint\/\d+\//, '/eslint/<timestamp>/'),
32-
}),
33-
outputFile: toUnixPath(
34-
(plugin.runner as RunnerConfig).outputFile,
35-
).replace(/\/eslint\/\d+\//, '/eslint/<timestamp>/'),
36-
},
37-
});
38-
3917
beforeAll(() => {
4018
cwdSpy = vi.spyOn(process, 'cwd');
4119
// Linux produces extra quotation marks for globs
@@ -55,7 +33,7 @@ describe('eslintPlugin', () => {
5533
patterns: ['src/**/*.js', 'src/**/*.jsx'],
5634
});
5735

58-
expect(replaceAbsolutePath(plugin)).toMatchSnapshot({
36+
expect(plugin).toMatchSnapshot({
5937
version: expect.any(String),
6038
});
6139
});

0 commit comments

Comments
 (0)