refactor(ci): avoid hardcoded default concurrency for turborepo and pnpm

Author: matejchalk

packages/ci/src/lib/monorepo/handlers/pnpm.ts

@@ -11,9 +11,6 @@ import type { MonorepoToolHandler } from '../tools.js';
 
 const WORKSPACE_FILE = 'pnpm-workspace.yaml';
 
-// https://pnpm.io/cli/recursive#--workspace-concurrency
-const DEFAULT_WORKSPACE_CONCURRENCY = 4;
-
 export const pnpmHandler: MonorepoToolHandler = {
   tool: 'pnpm',
 
@@ -46,16 +43,19 @@ export const pnpmHandler: MonorepoToolHandler = {
   },
 
   createRunManyCommand(options, projects) {
-    const workspaceConcurrency: number =
+    // https://pnpm.io/cli/recursive#--workspace-concurrency
+    const workspaceConcurrency: number | null =
       options.parallel === true
-        ? DEFAULT_WORKSPACE_CONCURRENCY
+        ? null
         : options.parallel === false
           ? 1
           : options.parallel;
     return [
       'pnpm',
       '--recursive',
-      `--workspace-concurrency=${workspaceConcurrency}`,
+      ...(workspaceConcurrency == null
+        ? []
+        : [`--workspace-concurrency=${workspaceConcurrency}`]),
       ...(projects.only?.map(project => `--filter=${project}`) ?? []),
       options.task,
     ].join(' ');

packages/ci/src/lib/monorepo/handlers/pnpm.unit.test.ts

@@ -198,13 +198,13 @@ describe('pnpmHandler', () => {
       );
     });
 
-    it('should set parallel flag with default number of jobs', () => {
+    it('should leave default concurrency if parallel flag is true', () => {
       expect(
         pnpmHandler.createRunManyCommand(
           { ...options, parallel: true },
           projects,
         ),
-      ).toBe('pnpm --recursive --workspace-concurrency=4 code-pushup');
+      ).toBe('pnpm --recursive code-pushup');
     });
 
     it('should set parallel flag with custom number of jobs', () => {

packages/ci/src/lib/monorepo/handlers/turbo.ts

@@ -7,9 +7,6 @@ import { yarnHandler } from './yarn.js';
 
 const WORKSPACE_HANDLERS = [pnpmHandler, yarnHandler, npmHandler];
 
-// https://turbo.build/repo/docs/reference/run#--concurrency-number--percentage
-const DEFAULT_CONCURRENCY = 10;
-
 type TurboConfig = {
   tasks: Record<string, object>;
 };
@@ -47,9 +44,10 @@ export const turboHandler: MonorepoToolHandler = {
   },
 
   createRunManyCommand(options, projects) {
-    const concurrency: number =
+    // https://turbo.build/repo/docs/reference/run#--concurrency-number--percentage
+    const concurrency: number | null =
       options.parallel === true
-        ? DEFAULT_CONCURRENCY
+        ? null
         : options.parallel === false
           ? 1
           : options.parallel;
@@ -59,7 +57,7 @@ export const turboHandler: MonorepoToolHandler = {
       'run',
       options.task,
       ...(projects.only?.map(project => `--filter=${project}`) ?? []),
-      `--concurrency=${concurrency}`,
+      ...(concurrency == null ? [] : [`--concurrency=${concurrency}`]),
       '--',
     ].join(' ');
   },

packages/ci/src/lib/monorepo/handlers/turbo.unit.test.ts

@@ -191,13 +191,13 @@ describe('turboHandler', () => {
       );
     });
 
-    it('should set parallel flag with default number of jobs', () => {
+    it('should leave default concurrency if parallel flag is true', () => {
       expect(
         turboHandler.createRunManyCommand(
           { ...options, parallel: true },
           projects,
         ),
-      ).toBe('npx turbo run code-pushup --concurrency=10 --');
+      ).toBe('npx turbo run code-pushup --');
     });
 
     it('should set parallel flag with custom number of jobs', () => {