Skip to content

Commit 7378bcc

Browse files
committed
fix: fix lint
1 parent 57e05dc commit 7378bcc

File tree

5 files changed

+10
-11
lines changed

5 files changed

+10
-11
lines changed

packages/nx-plugin/src/plugin/plugin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export const createNodes: CreateNodes = [
1313
async (
1414
projectConfigurationFile: string,
1515
createNodesOptions: unknown,
16-
context: CreateNodesContext,
16+
_: CreateNodesContext,
1717
): Promise<CreateNodesResult> => {
1818
const projectJson = await loadProjectConfiguration(
1919
projectConfigurationFile,

packages/nx-plugin/src/plugin/target/targets.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import { ProjectConfiguration } from '@nx/devkit';
1+
import type { ProjectConfiguration } from '@nx/devkit';
22
import { readdir } from 'node:fs/promises';
33
import { CP_TARGET_NAME } from '../constants';
4-
import { NormalizedCreateNodesOptions } from '../types';
4+
import type { NormalizedCreateNodesOptions } from '../types';
55
import { createConfigurationTarget } from './configuration-target';
66
import { CODE_PUSHUP_CONFIG_REGEX } from './constants';
77
import { createExecutorTarget } from './executor-target';

packages/nx-plugin/src/plugin/target/targets.unit.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ProjectConfiguration } from '@nx/devkit';
1+
import type { ProjectConfiguration } from '@nx/devkit';
22
import { vol } from 'memfs';
33
import { rm } from 'node:fs/promises';
44
import { afterEach, beforeEach, expect } from 'vitest';
@@ -40,7 +40,6 @@ describe('createTargets', () => {
4040
});
4141

4242
it('should return configuration targets for empty project without code-pushup config and consider targetName', async () => {
43-
const projectName = 'plugin-my-plugin';
4443
const targetName = 'cp';
4544
await expect(
4645
createTargets(projectConfig, { targetName }),

packages/nx-plugin/src/plugin/utils.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import { ProjectConfiguration } from '@nx/devkit';
1+
import type { ProjectConfiguration } from '@nx/devkit';
22
import { readFile } from 'node:fs/promises';
33
import { dirname, join } from 'node:path';
44
import { CP_TARGET_NAME } from './constants';
55
import { createTargets } from './target/targets';
6-
import { CreateNodesOptions, NormalizedCreateNodesOptions } from './types';
6+
import type { CreateNodesOptions, NormalizedCreateNodesOptions } from './types';
77

88
export function normalizeCreateNodesOptions(
99
options: unknown = {},
@@ -18,10 +18,10 @@ export function normalizeCreateNodesOptions(
1818
export async function loadProjectConfiguration(
1919
projectConfigurationFile: string,
2020
): Promise<ProjectConfiguration> {
21-
const projectConfiguration: ProjectConfiguration = await readFile(
21+
const projectConfiguration = (await readFile(
2222
join(process.cwd(), projectConfigurationFile),
2323
'utf8',
24-
).then(JSON.parse);
24+
).then(JSON.parse)) as Omit<ProjectConfiguration, 'root'> & { root?: string };
2525
if (
2626
!('name' in projectConfiguration) ||
2727
typeof projectConfiguration.name !== 'string'
@@ -30,7 +30,7 @@ export async function loadProjectConfiguration(
3030
}
3131
return {
3232
...projectConfiguration,
33-
root: projectConfiguration?.root ?? dirname(projectConfigurationFile),
33+
root: projectConfiguration.root ?? dirname(projectConfigurationFile),
3434
};
3535
}
3636

packages/nx-plugin/src/plugin/utils.unit.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { vol } from 'memfs';
2-
import { beforeEach, describe, expect } from 'vitest';
2+
import { describe, expect } from 'vitest';
33
import { MEMFS_VOLUME } from '@code-pushup/test-utils';
44
import * as targets from './target/targets';
55
import {

0 commit comments

Comments
 (0)