test(plugin-eslint): fix nx project graph for mocked monorepo

vmasek · vmasek · commit 6e166587b79a · 2024-09-05T20:27:36.000+02:00
Signed-off-by: Vojtech Masek &lt;vojtech@flowup.cz&gt;
diff --git a/packages/plugin-eslint/mocks/fixtures/nx-monorepo/.gitignore b/packages/plugin-eslint/mocks/fixtures/nx-monorepo/.gitignore
@@ -1 +1 @@
-.nx/cache
+.nx
diff --git a/packages/plugin-eslint/mocks/fixtures/nx-monorepo/packages/cli/project.json b/packages/plugin-eslint/mocks/fixtures/nx-monorepo/packages/cli/project.json
@@ -2,15 +2,13 @@
   "name": "cli",
   "sourceRoot": "packages/cli/src",
   "projectType": "application",
+  "implicitDependencies": ["core"],
   "targets": {
     "lint": {
       "executor": "@nx/linter:eslint",
       "outputs": ["{options.outputFile}"],
       "options": {
-        "lintFilePatterns": [
-          "packages/cli/**/*.ts",
-          "packages/cli/package.json"
-        ]
+        "lintFilePatterns": ["packages/cli/**/*.ts"]
       }
     }
   }
diff --git a/packages/plugin-eslint/mocks/fixtures/nx-monorepo/packages/core/project.json b/packages/plugin-eslint/mocks/fixtures/nx-monorepo/packages/core/project.json
@@ -2,15 +2,13 @@
   "name": "core",
   "sourceRoot": "packages/core/src",
   "projectType": "library",
+  "implicitDependencies": ["utils"],
   "targets": {
     "lint": {
       "executor": "@nx/linter:eslint",
       "outputs": ["{options.outputFile}"],
       "options": {
-        "lintFilePatterns": [
-          "packages/core/**/*.ts",
-          "packages/core/package.json"
-        ]
+        "lintFilePatterns": ["packages/core/**/*.ts"]
       }
     }
   }
diff --git a/packages/plugin-eslint/mocks/fixtures/nx-monorepo/packages/nx-plugin/project.json b/packages/plugin-eslint/mocks/fixtures/nx-monorepo/packages/nx-plugin/project.json
@@ -2,16 +2,13 @@
   "name": "nx-plugin",
   "sourceRoot": "packages/nx-plugin/src",
   "projectType": "library",
+  "implicitDependencies": ["utils"],
   "targets": {
     "lint": {
       "executor": "@nx/linter:eslint",
       "outputs": ["{options.outputFile}"],
       "options": {
-        "lintFilePatterns": [
-          "packages/nx-plugin/**/*.ts",
-          "packages/nx-plugin/package.json",
-          "packages/nx-plugin/generators.json"
-        ]
+        "lintFilePatterns": ["packages/nx-plugin/**/*.ts"]
       }
     }
   }
diff --git a/packages/plugin-eslint/mocks/fixtures/nx-monorepo/packages/utils/project.json b/packages/plugin-eslint/mocks/fixtures/nx-monorepo/packages/utils/project.json
@@ -7,10 +7,7 @@
       "executor": "@nx/linter:eslint",
       "outputs": ["{options.outputFile}"],
       "options": {
-        "lintFilePatterns": [
-          "packages/utils/**/*.ts",
-          "packages/utils/package.json"
-        ]
+        "lintFilePatterns": ["packages/utils/**/*.ts"]
       }
     }
   }
diff --git a/packages/plugin-eslint/mocks/fixtures/nx-monorepo/tsconfig.base.json b/packages/plugin-eslint/mocks/fixtures/nx-monorepo/tsconfig.base.json
@@ -8,9 +8,9 @@
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "importHelpers": true,
-    "target": "es2015",
+    "target": "ES2022",
     "module": "esnext",
-    "lib": ["es2020", "dom"],
+    "lib": ["ES2022", "dom"],
     "skipLibCheck": true,
     "skipDefaultLibCheck": true,
     "baseUrl": ".",
diff --git a/packages/plugin-eslint/src/lib/nx.integration.test.ts b/packages/plugin-eslint/src/lib/nx.integration.test.ts
@@ -45,7 +45,6 @@ describe('Nx helpers', () => {
           eslintrc: './packages/cli/.eslintrc.json',
           patterns: [
             'packages/cli/**/*.ts',
-            'packages/cli/package.json',
             'packages/cli/src/*.spec.ts',
             'packages/cli/src/*.cy.ts',
             'packages/cli/src/*.stories.ts',
@@ -56,7 +55,6 @@ describe('Nx helpers', () => {
           eslintrc: './packages/core/.eslintrc.json',
           patterns: [
             'packages/core/**/*.ts',
-            'packages/core/package.json',
             'packages/core/src/*.spec.ts',
             'packages/core/src/*.cy.ts',
             'packages/core/src/*.stories.ts',
@@ -67,8 +65,6 @@ describe('Nx helpers', () => {
           eslintrc: './packages/nx-plugin/.eslintrc.json',
           patterns: [
             'packages/nx-plugin/**/*.ts',
-            'packages/nx-plugin/package.json',
-            'packages/nx-plugin/generators.json',
             'packages/nx-plugin/src/*.spec.ts',
             'packages/nx-plugin/src/*.cy.ts',
             'packages/nx-plugin/src/*.stories.ts',
@@ -79,7 +75,6 @@ describe('Nx helpers', () => {
           eslintrc: './packages/utils/.eslintrc.json',
           patterns: [
             'packages/utils/**/*.ts',
-            'packages/utils/package.json',
             'packages/utils/src/*.spec.ts',
             'packages/utils/src/*.cy.ts',
             'packages/utils/src/*.stories.ts',

Original file line number	Diff line number	Diff line change
`@@ -2,15 +2,13 @@`
`2`	`2`	`"name": "cli",`
`3`	`3`	`"sourceRoot": "packages/cli/src",`
`4`	`4`	`"projectType": "application",`
	`5`	`+ "implicitDependencies": ["core"],`
`5`	`6`	`"targets": {`
`6`	`7`	`"lint": {`
`7`	`8`	`"executor": "@nx/linter:eslint",`
`8`	`9`	`"outputs": ["{options.outputFile}"],`
`9`	`10`	`"options": {`
`10`		`- "lintFilePatterns": [`
`11`		`- "packages/cli/*/.ts",`
`12`		`- "packages/cli/package.json"`
`13`		`- ]`
	`11`	`+ "lintFilePatterns": ["packages/cli/*/.ts"]`
`14`	`12`	`}`
`15`	`13`	`}`
`16`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,15 +2,13 @@`
`2`	`2`	`"name": "core",`
`3`	`3`	`"sourceRoot": "packages/core/src",`
`4`	`4`	`"projectType": "library",`
	`5`	`+ "implicitDependencies": ["utils"],`
`5`	`6`	`"targets": {`
`6`	`7`	`"lint": {`
`7`	`8`	`"executor": "@nx/linter:eslint",`
`8`	`9`	`"outputs": ["{options.outputFile}"],`
`9`	`10`	`"options": {`
`10`		`- "lintFilePatterns": [`
`11`		`- "packages/core/*/.ts",`
`12`		`- "packages/core/package.json"`
`13`		`- ]`
	`11`	`+ "lintFilePatterns": ["packages/core/*/.ts"]`
`14`	`12`	`}`
`15`	`13`	`}`
`16`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,16 +2,13 @@`
`2`	`2`	`"name": "nx-plugin",`
`3`	`3`	`"sourceRoot": "packages/nx-plugin/src",`
`4`	`4`	`"projectType": "library",`
	`5`	`+ "implicitDependencies": ["utils"],`
`5`	`6`	`"targets": {`
`6`	`7`	`"lint": {`
`7`	`8`	`"executor": "@nx/linter:eslint",`
`8`	`9`	`"outputs": ["{options.outputFile}"],`
`9`	`10`	`"options": {`
`10`		`- "lintFilePatterns": [`
`11`		`- "packages/nx-plugin/*/.ts",`
`12`		`- "packages/nx-plugin/package.json",`
`13`		`- "packages/nx-plugin/generators.json"`
`14`		`- ]`
	`11`	`+ "lintFilePatterns": ["packages/nx-plugin/*/.ts"]`
`15`	`12`	`}`
`16`	`13`	`}`
`17`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,10 +7,7 @@`
`7`	`7`	`"executor": "@nx/linter:eslint",`
`8`	`8`	`"outputs": ["{options.outputFile}"],`
`9`	`9`	`"options": {`
`10`		`- "lintFilePatterns": [`
`11`		`- "packages/utils/*/.ts",`
`12`		`- "packages/utils/package.json"`
`13`		`- ]`
	`10`	`+ "lintFilePatterns": ["packages/utils/*/.ts"]`
`14`	`11`	`}`
`15`	`12`	`}`
`16`	`13`	`}`