wip

Author: BioPhoton

packages/plugin-typescript/src/lib/runner/ts-error-codes.ts

@@ -75,7 +75,7 @@ export const TS_ERROR_CODES = {
     disableSourceOfProjectReferenceRedirect: [6374],
   } as const,*/
   moduleResolution: {
-    moduleResolution: [2307, 1479],
+    moduleResolution: [2307, 1479, 2792],
     customConditions: [1378],
     resolvePackageJsonExports: [1343],
     resolvePackageJsonImports: [1344],
@@ -84,7 +84,7 @@ export const TS_ERROR_CODES = {
   typeCheckingBehavior: {
     // noErrorTruncation: [2322, 2345], // This affects error message display rather than triggering specific errors
     exactOptionalPropertyTypes: [2775],
-    noUncheckedIndexedAccess: [7061],
+    noUncheckedIndexedAccess: [7061, 2536],
     noImplicitOverride: [4114, 4113],
     noPropertyAccessFromIndexSignature: [4111],
   } as const,

packages/plugin-typescript/src/lib/typescript-plugin.ts

@@ -15,21 +15,16 @@ export async function typescriptPlugin(
 
   const filteredAudits = AUDITS
     .filter(filterAuditsByTsOptions(definitive, options?.onlyAudits));
+  const filteredGroups = getGroups(definitive, options);
 
   const skippedAudits = AUDITS
     .filter(audit => !filteredAudits.some(filtered => filtered.slug === audit.slug))
     .map(audit => kebabCaseToCamelCase(audit.slug));
 
   if(skippedAudits.length > 0){
-    console.warn(`Some audits were skipped: [${skippedAudits.join(', ')}]`);
+    console.warn(`Some audits were skipped because the configuration of the compiler options [${skippedAudits.join(', ')}]`);
   }
 
-  console.info('filteredAudits', Object.keys(filteredAudits).length);
-  console.info('AUDITS', Object.keys(AUDITS).length);
-  console.info('audits', AUDITS.map(audit => audit.slug));
-
-  const filteredGroups = getGroups(definitive, options?.onlyAudits);
-  console.log(filteredGroups.length, 'CANTIDAD');
   return {
     slug: TYPESCRIPT_PLUGIN_SLUG,
     packageName,

packages/plugin-typescript/src/lib/utils.ts

@@ -31,6 +31,7 @@ export function filterAuditsBySlug(slugs?: string[]) {
  * @returns The slug as compilerOption key
  */
 export function auditSlugToCompilerOption(slug: string): string {
+  // eslint-disable-next-line sonarjs/no-small-switch
   switch (slug) {
     case 'emit-bom':
       return 'emitBOM';
@@ -39,14 +40,16 @@ export function auditSlugToCompilerOption(slug: string): string {
   }
 }
 
+/**
+ * From a list of audits, it will filter out the ones that might have been disabled from the compiler options
+ * plus from the parameter onlyAudits
+ * @param compilerOptions Compiler options
+ * @param onlyAudits OnlyAudits
+ * @returns Filtered Audits
+ */
 export function filterAuditsByTsOptions(compilerOptions: CompilerOptions, onlyAudits?: string[]) {
   return ({slug}: { slug: string }) => {
     const option = compilerOptions[auditSlugToCompilerOption(slug)];
-    if (slug === 'emit-bom') {
-      console.log('-----------------------')
-      console.log(option, slug)
-      console.log((option !== false && option !== undefined) && filterAuditsBySlug(onlyAudits))
-    }
     return (option !== false && option !== undefined) && filterAuditsBySlug(onlyAudits);
   };
 }
@@ -55,15 +58,8 @@ export function filterGroupsByAuditSlug(slugs?: string[]) {
   return ({refs}: Group) => refs.some(filterAuditsBySlug(slugs));
 }
 
-export function filterGroupsByTsOptions(compilerOptions: CompilerOptions, onlyAudits?: string[]) {
-  console.log(compilerOptions.emitBOM);
-  console.log(filterAuditsByTsOptions(compilerOptions, onlyAudits), 'filtered')
-  console.log('nuevoo')
-  return ({refs}: Group) => refs.filter(filterAuditsByTsOptions(compilerOptions, onlyAudits));
-}
-
 
-export function getGroups(compilerOptions: CompilerOptions, onlyAudits?: string[]) {
+export function getGroups(compilerOptions: CompilerOptions, {onlyAudits}: TypescriptPluginOptions) {
   return GROUPS
     .map(group => ({
       ...group,
@@ -81,7 +77,6 @@ export function getGroups(compilerOptions: CompilerOptions, onlyAudits?: string[
 export async function getCategoryRefsFromGroups(opt?: TypescriptPluginOptions): Promise<CategoryRef[]> {
 
   const definitive = await getCompilerOptionsToDetermineListedAudits(opt);
-
   return GROUPS
     .map(group => ({
       ...group,